Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 8, 2025

This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@chenyukang
Copy link
Member

@bors r=chenyukang

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

📌 Commit 849feea has been approved by chenyukang

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 8, 2025
…ukang

Add a test for the cold attribute

This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 8, 2025
…ukang

Add a test for the cold attribute

This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.
bors added a commit that referenced this pull request Oct 8, 2025
Rollup of 6 pull requests

Successful merges:

 - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition)
 - #147420 (Add diagnostic items for `pub mod consts` of FP types)
 - #147467 (Fix double warnings on `#[no_mangle]`)
 - #147476 (Add a test for the cold attribute)
 - #147480 (Do not invalidate CFG caches in CtfeLimit.)
 - #147481 (format: some small cleanup)

r? `@ghost`
`@rustbot` modify labels: rollup
@chenyukang
Copy link
Member

@bors r-
seems failed for: #147492 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2025
This adds a test for the cold attribute to verify that it actually does
something, and that it applies correctly in all the positions it is
expected to work.
@ehuss ehuss force-pushed the cold-attribute-test branch from 849feea to 50e1884 Compare October 10, 2025 03:24
@ehuss
Copy link
Contributor Author

ehuss commented Oct 10, 2025

I was worried that the exact match could be a problem there. I have updated it to use CHECK-NOT which I think should be more robust, and tested that job in docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants