remove intrinsic wrapper functions from LLVM bindings #147509
+28
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
Zalathar
reviewed
Oct 9, 2025
|
Nitpick: I think calling this a “refactor” is more confusing than helpful. While the end result is the same, from an internal perspective this is enough of a cross-system behavioural change that I would prefer not to use that term here. I'll rename this PR; please rename the individual commit and force-push. |
Zalathar
changed the title
|
r? Zalathar |
AMS21
force-pushed
the
remove_llvm_rust_intrinsics
branch
2 times, most recently
from
7d9f8e0 to
281d0ba
Compare
AMS21
force-pushed
the
remove_llvm_rust_intrinsics
branch
from
281d0ba to
064e3b8
Compare
|
Looks good, thanks. @bors r+ |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 9, 2025
… r=Zalathar remove intrinsic wrapper functions from LLVM bindings As discussed on llvm/llvm-project#162500 there is no good reason to implement these intrinsic function via the LLVM wrapper instead we now just implement them via `call_intrinsic` like all the other intrinsic functions. Work towards rust-lang#46437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on llvm/llvm-project#162500 there is no good reason to implement these intrinsic function via the LLVM wrapper instead we now just implement them via
call_intrinsiclike all the other intrinsic functions.Work towards #46437