Rollup of 7 pull requests #147510

Zalathar · 2025-10-09T06:53:11Z

Successful merges:

Port the implemention of SIMD intrinsics from Miri to const-eval #146568 (Port the implemention of SIMD intrinsics from Miri to const-eval)
give a better example why std modules named like primitives are needed #147373 (give a better example why std modules named like primitives are needed)
bootstrap: add Builder::rustc_cmd that includes the lib path #147419 (bootstrap: add Builder::rustc_cmd that includes the lib path)
specialize slice::fill to use memset when possible #147457 (specialize slice::fill to use memset when possible)
Implement fs api set_times and set_times_nofollow #147468 (Implement fs api set_times and set_times_nofollow)
Prefer to use repeat_n over repeat().take() #147489 (Prefer to use repeat_n over repeat().take())
compiletest: Isolate public APIs and minimize public surface area #147506 (compiletest: Isolate public APIs and minimize public surface area)

r? @ghost
@rustbot modify labels: rollup

When building with `rust.rpath = false`, every `rustc` invocation needs to include the library path as well. I particularly ran into this in `generate_target_spec_json_schema` when testing 1.91-beta in Fedora, where we do disable rpath for our system builds. The new helper function will hopefully encourage the right thing going forward.

…tion for reusing it

LLVM generally can do this on its own, but it helps miri and other backends.

Co-authored-by: Josh Triplett <[email protected]>

All APIs used from outside the compiletest library crate have been isolated to the `cli` and `rustdoc_gui_test` modules, so no other items need to be publicly exported.

Co-authored-by: Josh Triplett <[email protected]>

Port the implemention of SIMD intrinsics from Miri to const-eval Ported the implementation of most SIMD intrinsics from Miri to rustc_const_eval. Remaining are - Math functions (as per `@RalfJung's` suggestions) - FMA (non-deterministic) - Funnel Shifts (not implemented in Miri yet) - Unordered reduction intrinsics (not implemented in Miri yet)

…mdev give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to rust-lang#146882.

…lathar,jieyouxu bootstrap: add `Builder::rustc_cmd` that includes the lib path When building with `rust.rpath = false`, every `rustc` invocation needs to include the library path as well. I particularly ran into this in `generate_target_spec_json_schema` when testing 1.91-beta in Fedora, where we do disable rpath for our system builds. The new helper function will hopefully encourage the right thing going forward.

…Jung,joboet specialize slice::fill to use memset when possible It helps const eval performance rust-lang/miri#4616, debug builds and the gcc backend. Previously attempted in rust-lang#83245 but reverted due to unsoundness rust-lang#87891 around potentially-uninitialized types. This PR only handles primitives where the problem does not arise. split off from rust-lang#147294

…=joshtriplett Implement fs api set_times and set_times_nofollow implementation of rust-lang#147455 r? `@joshtriplett`

… r=Kivooeo,oli-obk Prefer to use repeat_n over repeat().take() More from rust-lang#147464, but batch processed with `ast-grep` to find and replace. second commit add notes for library: rust-lang@affaf53 r? `@RalfJung`

compiletest: Isolate public APIs and minimize public surface area As part of my ongoing efforts to improve directive parsing, I would like to be able to make internal changes without worrying about whether they're going to break the rustdoc-gui-test tool. That tool currently uses compiletest as a dependency to help with directive parsing. This PR therefore isolates all of compiletest's public APIs into two dedicated modules, one used by rustdoc-gui-test, and one used by the compiletest binary in `compiletest/src/bin/main.rs`. All other modules (and crate-root items) are then made non-`pub` to achieve the API isolation. Doing so reveals some unused items, which have been removed. (To reduce the amount of immediate textual churn, this PR does not comprehensively replace `pub` with `pub(crate)` throughout the whole crate; that could be done in a follow-up PR.) --- Ideally, rustdoc-gui-test would not depend on compiletest at all, but properly fixing that is out of scope for this PR. - rust-lang#143827 r? jieyouxu

Zalathar · 2025-10-09T06:53:36Z

Rollup of everything not in #147505.

@bors r+ rollup=never p=5

bors · 2025-10-09T06:53:39Z

📌 Commit c34587e has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-10-09T06:58:09Z

⌛ Testing commit c34587e with merge 5aba379...

Rollup of 7 pull requests Successful merges: - #146568 (Port the implemention of SIMD intrinsics from Miri to const-eval) - #147373 (give a better example why `std` modules named like primitives are needed) - #147419 (bootstrap: add `Builder::rustc_cmd` that includes the lib path) - #147457 (specialize slice::fill to use memset when possible) - #147468 (Implement fs api set_times and set_times_nofollow) - #147489 (Prefer to use repeat_n over repeat().take()) - #147506 (compiletest: Isolate public APIs and minimize public surface area) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-10-09T07:34:11Z

The job dist-android failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] object test:false 6.029
error[E0412]: cannot find type `c_char` in this scope
    --> library/std/src/sys/fs/unix.rs:2149:61
     |
2149 |                     fn utimensat(dirfd: c_int, path: *const c_char, times: *const libc::timespec, flags: c_int) -> c_int;
     |                                                             ^^^^^^
     |
help: a builtin type with a similar name exists
     |
2149 -                     fn utimensat(dirfd: c_int, path: *const c_char, times: *const libc::timespec, flags: c_int) -> c_int;
2149 +                     fn utimensat(dirfd: c_int, path: *const char, times: *const libc::timespec, flags: c_int) -> c_int;
     |
help: consider importing one of these type aliases
     |
  11 + use crate::ffi::c_char;
     |

bors · 2025-10-09T07:34:56Z

💔 Test failed - checks-actions

cyrgani and others added 27 commits October 5, 2025 13:58

give a better example why std modules named like primitives are needed

0bc6945

library: fs: Factor out a file_time_to_timespec function in prepara…

1e6b444

…tion for reusing it

library: fs: Factor out the Apple file time to attrlist code for reuse

1bf555c

Port the Miri implementations of SIMD intrinsics to rustc_const_eval

45ca537

prefer to use repeat_n over repeat and take

1654cce

referring to repeat_n in std::iter::repeat

affaf53

bless format

53c79f4

specialize slice::fill to use memset when possible

99ab27f

LLVM generally can do this on its own, but it helps miri and other backends.

Implement fs api set_times and set_times_nofollow

7225454

Update library/std/src/fs.rs

3d40fa6

Co-authored-by: Josh Triplett <[email protected]>

Update library/std/src/fs.rs

6308e76

Co-authored-by: Josh Triplett <[email protected]>

compiletest: Isolate APIs used by rustdoc-gui-test

8f08156

compiletest: Isolate APIs used by bin/main.rs

b4f64fd

compiletest: Make all other modules non-public

ce4699d

All APIs used from outside the compiletest library crate have been isolated to the `cli` and `rustdoc_gui_test` modules, so no other items need to be publicly exported.

use proper unsupported

1c5c8ca

rebase rust-lang#147504

46c6f0a

support fs::set_times for wasi

2438df7

add doc alias for set_times_nofollow

1dd5641

Co-authored-by: Josh Triplett <[email protected]>

add doc alias for set_times

6fd1c2b

Co-authored-by: Josh Triplett <[email protected]>

Rollup merge of rust-lang#147468 - chenyukang:yukang-api-set-times, r…

fd19065

…=joshtriplett Implement fs api set_times and set_times_nofollow implementation of rust-lang#147455 r? `@joshtriplett`

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Oct 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2025

Zalathar mentioned this pull request Oct 9, 2025

Implement fs api set_times and set_times_nofollow #147468

Open

Zalathar closed this Oct 9, 2025

Zalathar deleted the rollup-zlcd471 branch October 9, 2025 11:20

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #147510

Rollup of 7 pull requests #147510

Zalathar commented Oct 9, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Oct 9, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

rust-log-analyzer commented Oct 9, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #147510

Rollup of 7 pull requests #147510

Conversation

Zalathar commented Oct 9, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 9, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

rust-log-analyzer commented Oct 9, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

Uh oh!

Zalathar commented Oct 9, 2025 •

edited by rustbot

Loading