-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Port the remaining SIMD intrinsics to const-eval #147520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
344e3dc
to
b8a4c23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Here are some first comments.
All of the new intrinsics Miri supports with this will also need Miri tests.
Please update the PR description: This doesn't actually add anything in const-eval, it adds it to the interpreter and then only exposes this in Miri. |
- refactor float rounding intrinsics a bit
b8a4c23
to
69a2513
Compare
successor to #146568, this refactors some implementations and ports the implementation of
simd_fma
andsimd_relaxed_fma
torustc_const_eval
Also adds some remaining f16/f128 support in these intrinsics
r? @RalfJung