Rollup of 8 pull requests #147603
Merged
Rollup of 8 pull requests #147603
+698
−409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to rust-lang#137400. The current macro is incredibly complicated and introduces subtle bugs like calling the `extend_one` of the individual collections in backwards order. This PR drastically simplifies the macro by removing recursion and moving the specialization out of the macro. It also fixes the ordering issue described above (I've stolen the test of the new behaviour from rust-lang#137400). Additionally, the 1-tuple is now special-cased to allow taking advantage of the well-optimized `Extend` implementations of the individual collection.
ordering of side-effects to `coretest`.
Most new API has an associated ACP that is useful to reference, but it doesn't appear anywhere on the template for new tracking issues. Update this template to include a link to the ACP.
Since `LLVMRustContextCreate` can easily be replaced with a call to `LLVMContextCreate` and `LLVMContextSetDiscardValueNames`.
Currently x.py help (or x.py --help) builds bootstrap binary everytime, but it delays printing help. This change saves the current top level help text into a file. x.py help prints the file and doesn't touch bootstrap binary. x.py test bootstrap checks if the file is up to date. Note that subcommand level helps (e.g., x.py check --help) aren't saved.
…crum core: simplify `Extend` for tuples This is an alternative to rust-lang#137400. The current macro is incredibly complicated and introduces subtle bugs like calling the `extend_one` of the individual collections in backwards order. This PR drastically simplifies the macro by removing recursion and moving the specialization out of the macro. It also fixes the ordering issue described above (I've stolen the test of the new behaviour from rust-lang#137400). Additionally, the 1-tuple is now special-cased to allow taking advantage of the well-optimized `Extend` implementations of the individual collection.
…r=jieyouxu Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [rust-lang#4 of Batch rust-lang#2] Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
…lacrum Save x.py's help text for saving output time Fix rust-lang#141903 Currently x.py help (--help) builds bootstrap binary everytime, so it takes some seconds to print help. This PR does: - Saves current help text into a file (x.py run generate-help) - Changes bootstrap.py to print the help in the saved file and to exit without touching bootstrap binary - Modifies x.py test bootstrap to check if the help file is up-to-date
…-Simulacrum Add an ACP list item to the library tracking issue template Most new API has an associated ACP that is useful to reference, but it doesn't appear anywhere on the template for new tracking issues. Update this template to include a link to the ACP.
…=Mark-Simulacrum Explain not existed key in BTreeMap::split_off Fixes rust-lang#147174 r? libs
Extract most code from `define_feedable!` This PR extracts most of the non-trivial code from the `define_feedable!` macro (which defines the `TyCtxtFeed::$query` methods), and moves it to a helper function `query_feed_inner` written in ordinary non-macro code. Doing so should make that code easier to read and modify, because it now gets proper IDE support and has explicit trait bounds. --- There should be no change in compiler behaviour. I've structured the commits so that the actual extraction part is mostly just whitespace changes, making it easier to review individually with whitespace changes hidden.
…joboet Fix documentation of Instant::now on mac It is `CLOCK_UPTIME_RAW` on Apple. https://github.com/rust-lang/rust/blob/b6f0945e4681bc4d2faa7c22c5f61dc36abf7dd2/library/std/src/sys/pal/unix/time.rs#L260-L264
…ate, r=Zalathar Replace `LLVMRustContextCreate` with normal LLVM-C API calls Since `LLVMRustContextCreate` can easily be replaced with a call to `LLVMContextCreate` and `LLVMContextSetDiscardValueNames`. Work towards rust-lang#46437
rustbot
added
A-LLVM
|
@bors r+ rollup=never p=5 |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 3be68033b6 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3be6803 (parent) -> 8927649 (this PR) Test differencesShow 484 test diffsStage 1
Stage 2
(and 14 additional test diffs) Additionally, 370 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 89276493d3c3f85691e76b27a9dde7ec82e79cdb --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Extendfor tuples #138799 (core: simplifyExtendfor tuples)tests/ui/issues/tests to other subdirectories undertests/ui/[#4 of Batch #2] #145897 (Rehome 30tests/ui/issues/tests to other subdirectories undertests/ui/[ add an IL type checker #4 of Batch bind's glue function should tail-call its target #2])define_feedable!#147393 (Extract most code fromdefine_feedable!)LLVMRustContextCreatewith normal LLVM-C API calls #147549 (ReplaceLLVMRustContextCreatewith normal LLVM-C API calls)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup