Skip to content

Conversation

cjgillot
Copy link
Contributor

r? @ghost for perf

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2025
@rust-log-analyzer

This comment was marked as outdated.

@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 12, 2025
Perform DestinationPropagation on places.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 12, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 13, 2025

☀️ Try build successful (CI)
Build commit: beffb46 (beffb46b22c244142de90ea73fcb24c3ec3e03a6, parent: 2300c2aef7dbc2a7bbbeaa9894d07d459abd9bc6)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (beffb46): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.9% [0.1%, 5.5%] 166
Regressions ❌
(secondary)
0.8% [0.1%, 3.7%] 158
Improvements ✅
(primary)
-0.9% [-2.0%, -0.1%] 12
Improvements ✅
(secondary)
-0.8% [-3.3%, -0.1%] 26
All ❌✅ (primary) 0.7% [-2.0%, 5.5%] 178

Max RSS (memory usage)

Results (primary 0.6%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.2% [0.4%, 5.9%] 5
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-3.6%, -1.7%] 4
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 1
All ❌✅ (primary) 0.6% [-3.6%, 5.9%] 9

Cycles

Results (primary 1.9%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [1.9%, 3.8%] 10
Regressions ❌
(secondary)
2.3% [1.4%, 4.2%] 14
Improvements ✅
(primary)
-1.4% [-1.6%, -1.2%] 2
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 1.9% [-1.6%, 3.8%] 12

Binary size

Results (primary -0.2%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.2% [0.0%, 0.7%] 40
Regressions ❌
(secondary)
0.4% [0.0%, 1.7%] 60
Improvements ✅
(primary)
-0.4% [-2.2%, -0.0%] 64
Improvements ✅
(secondary)
-0.4% [-2.2%, -0.0%] 71
All ❌✅ (primary) -0.2% [-2.2%, 0.7%] 104

Bootstrap: 472.507s -> 472.183s (-0.07%)
Artifact size: 388.12 MiB -> 387.74 MiB (-0.10%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 13, 2025
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 14, 2025
Perform DestinationPropagation on places.
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 14, 2025

☀️ Try build successful (CI)
Build commit: 7abf5cf (7abf5cf2df580e4433bd0c247bcdf18e1dab779b, parent: e100792918c8bd9e0cb830f96fc9b171e8892fa1)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7abf5cf): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.8% [0.1%, 4.9%] 165
Regressions ❌
(secondary)
0.8% [0.0%, 3.7%] 153
Improvements ✅
(primary)
-0.8% [-2.1%, -0.1%] 14
Improvements ✅
(secondary)
-0.8% [-3.4%, -0.1%] 30
All ❌✅ (primary) 0.7% [-2.1%, 4.9%] 179

Max RSS (memory usage)

Results (primary -1.7%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.6% [1.0%, 6.3%] 13
Improvements ✅
(primary)
-1.7% [-3.2%, -0.7%] 6
Improvements ✅
(secondary)
-2.1% [-2.6%, -1.2%] 4
All ❌✅ (primary) -1.7% [-3.2%, -0.7%] 6

Cycles

Results (primary 1.3%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [1.6%, 3.8%] 3
Regressions ❌
(secondary)
2.7% [1.7%, 4.3%] 12
Improvements ✅
(primary)
-2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 1.3% [-2.3%, 3.8%] 4

Binary size

Results (primary -0.2%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.3% [0.0%, 0.8%] 36
Regressions ❌
(secondary)
0.5% [0.1%, 1.7%] 16
Improvements ✅
(primary)
-0.4% [-2.2%, -0.0%] 69
Improvements ✅
(secondary)
-0.5% [-2.3%, -0.0%] 73
All ❌✅ (primary) -0.2% [-2.2%, 0.8%] 105

Bootstrap: 473.51s -> 471.623s (-0.40%)
Artifact size: 388.11 MiB -> 387.82 MiB (-0.07%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants