Skip to content

Conversation

jdonszelmann
Copy link
Contributor

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2025
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Oct 14, 2025

@rustbot author
@jdonszelmann CI has failed but I don't actually see a failed job, interesting?

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jdonszelmann
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2025
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI is green

View changes since this review

@JonathanBrouwer
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 14, 2025

📌 Commit 43d915c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025
bors added a commit that referenced this pull request Oct 15, 2025
Rollup of 7 pull requests

Successful merges:

 - #146841 (Stabilise `rotate_left` and `rotate_right` in `[_]` as `const fn` items.)
 - #146949 (Add vsx register support for ppc inline asm, and implement preserves_flag option)
 - #147539 (resolve: Use primitives for conditional mutability more consistently)
 - #147685 (remove span calls from deprecated attribute checking)
 - #147699 (Clairify docs for `AttributeKind::DocComment`)
 - #147706 (Add myself to review rotation)
 - #147711 (Clarify that UB will occur, not can/may in GlobalAlloc docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7203051 into rust-lang:master Oct 15, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 15, 2025
rust-timer added a commit that referenced this pull request Oct 15, 2025
Rollup merge of #147685 - jdonszelmann:deprecated-no-span, r=JonathanBrouwer

remove span calls from deprecated attribute checking

r? `@JonathanBrouwer`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants