Rollup of 11 pull requests #147745
Merged
Rollup of 11 pull requests #147745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Tsui <[email protected]>
Previously, the local crate would always be printed as a leading `crate::`.
Allow resolving it to the crate name instead.
This allows printing a fully qualified path with:
```rust
let qualified_name = with_no_visible_paths!(with_resolve_crate_name!(
with_no_trimmed_paths!(tcx.def_path_str(def_id))
));
```
I found this useful for an out-of-tree rustc-driver. I do not currently
have a usecase in mind upstream; I'm ok if you don't want this PR for
that reason.
This does not currently have tests. I am not aware of an easy way to
test def-id printing, since it requires having access to a TyCtxt.
Signed-off-by: zhetaicheleba <[email protected]>
Polonius liveness has to contain boring locals, and we ignore them in diagnostics to match NLL diagnostics, since they doesn't contain boring locals. We ignored these when explaining why a loan contained a point due to a use of a live var, but not when it contained a point due to a drop of a live var.
…grade, r=tgross35 Stabilize `rwlock_downgrade` library feature Tracking Issue: rust-lang#128203 Method to be stabilized: ```rust impl<'a, T: ?Sized> RwLockWriteGuard<'a, T> { pub fn downgrade(s: Self) -> RwLockReadGuard<'a, T> {} } ``` ~~I would like to point out that my documentation comment is longer than ideal, but at the same time I don't really know how else to show why `downgrade` is actually necessary (instead of just unlocking and relocking). If anyone has ideas for making this more concise that would be great!~~ I have made the documentation a bit more clear. Stabilization report: rust-lang#128203 (comment)
…ethercote
Allow printing a fully-qualified path in `def_path_str`
Previously, the local crate would always be printed as a leading `crate::`. Allow resolving it to the crate name instead.
This allows printing a fully qualified path with:
```rust
let qualified_name = with_no_visible_paths!(with_resolve_crate_name!(
with_no_trimmed_paths!(tcx.def_path_str(def_id))
));
```
I found this useful for an out-of-tree rustc-driver. I do not currently have a usecase in mind upstream; I'm ok if you don't want this PR for that reason. See [#t-compiler/help > print a fully qualified path name? @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/print.20a.20fully.20qualified.20path.20name.3F/near/541560961) for additional context.
This does not currently have tests. I am not aware of an easy way to test def-id printing, since it requires having access to a TyCtxt.
…, r=Kobzol Update t-compiler beta nomination Zulip msg Sister patch of [triagebot#2191](rust-lang/triagebot#2191) Follow-up to rust-lang#147263 The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take. The wording (as per [triagebot#2191](rust-lang/triagebot#2191)) is open to suggestions. Thanks
some `ErrorGuaranteed` cleanups If we've got an `ErrorGuaranteed`, use it.
…r=GuillaumeGomez Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes r? `@GuillaumeGomez`
const `mem::drop` I'm putting this under the `const Destruct` feature flag since it doesn't really feel relevant to put it elsewhere… it's just an empty function body, so, it doesn't have any particular weirdness attached to it (unlike `drop_in_place`, for example). r? wg-const-eval
…s-async, r=jackh726 Fix ICE when using contracts on async functions Fixes rust-lang#145333 contract is not supported for async functions right now, it's not properly lowered and getting HirId will ICE. This PR adds checking for async function in expanding AST phase, it's better until we want to fully support async for contracts feature.
Fix some comments Fix some comments
…nts, r=bjorn3 miri: use allocator_shim_contents codegen helper r? `@bjorn3` Follow-up to rust-lang#147526, also using that new infrastructure in Miri.
ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius Polonius liveness has to contain boring locals, and we ignore them in diagnostics, to match NLL diagnostics that never involve any boring locals. When explaining why a borrow contains a point, I ignored these boring locals when it was due to a use of a live var, but forgot to do so when the cause was because of a drop of a live var. This is what was causing the last two (known) diagnostics differences under the polonius compare-mode: - `tests/ui/dropck/dropck_trait_cycle_checked.rs` - `tests/ui/unboxed-closures/unboxed-closures-failed-recursive-fn-1.rs` r? `@jackh726`
…RalfJung Revert unintentional whitespace changes to rustfmt-excluded file Accidentally introduced in rust-lang#143548
rustbot
added
A-attributes
rustbot
added
T-libs
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 57ef8d6 (parent) -> 402ce0e (this PR) Test differencesShow 80 test diffsStage 1
Stage 2
Additionally, 78 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 402ce0ef07d5db9ba26ae5c37ce6aff0c9002052 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 57ef8d642d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (402ce0e): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.6%, secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 476.546s -> 474.904s (-0.34%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rwlock_downgradelibrary feature #143191 (Stabilizerwlock_downgradelibrary feature)def_path_str#147444 (Allow printing a fully-qualified path indef_path_str)ErrorGuaranteedcleanups #147670 (someErrorGuaranteedcleanups)is_doc_commentto reduce reliance on.span()on attributes #147676 (Return spans out ofis_doc_commentto reduce reliance on.span()on attributes)mem::drop#147708 (constmem::drop)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup