-
Notifications
You must be signed in to change notification settings - Fork 14k
compiletest: Use //@ prefixes also for debuginfo test directives
#147799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
74887a7 to
1f5cd0c
Compare
//@ prefixes also for debuginfo test directives//@ prefixes also for debuginfo test directives
This comment has been minimized.
This comment has been minimized.
1f5cd0c to
9ec7434
Compare
|
@bors try jobs=x86_64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: x86_64-msvc-1
9ec7434 to
19de8a2
Compare
|
@bors try jobs=x86_64-msvc-1 |
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: x86_64-msvc-1
This comment has been minimized.
This comment has been minimized.
|
x86_64-msvc-1 does not have cdb it seems, but I think aarch64 does: @bors try jobs=aarch64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 8aa08e9 failed: CI. Failed jobs:
|
|
According to #t-compiler/debuginfo > debuginfo-lldb CI job? we need to run @bors try jobs=aarch64-apple |
This comment has been minimized.
This comment has been minimized.
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 7e46723 failed: CI. Failed jobs:
|
19de8a2 to
10bf1c1
Compare
|
I have now confirmed that gdb, lldb, and cdb tests can still fail, so this is ready for review. Click to expand list of confirmed test failures. |
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
|
☔ The latest upstream changes (presumably #147728) made this pull request unmergeable. Please resolve the merge conflicts. |
So that when we later add support for revisions we can use the same syntax for revisions as elsewhere. This also prevents people from making typos for commands since `src/tools/compiletest/src/directives/directive_names.rs` will catch such typos now. Note that we one FIXME for a non-trivial change for later: ``` // FIXME(148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure` ```
10bf1c1 to
17d8ae3
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Not applicable for this PR since debuginfo directives are still special. We just want the same syntax as for normal directives. Anyway, this PR is ready for review now. |
So that when we later add support for revisions we can use the same syntax for revisions as elsewhere.
This also prevents people from making typos for commands since
src/tools/compiletest/src/directives/directive_names.rswill catch such typos now.Note that we add one FIXME for a non-trivial change for later:
TODO
//@prefixes also for debuginfo test directives #147799 (comment)Zulip discussion
https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/.2F.2F.40.20syntax.20for.20debuginfo.20tests/with/545015582