Skip to content

Warn on unused_attributes in uitests #147813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2025
Merged

Warn on unused_attributes in uitests #147813

merged 2 commits into from
Oct 19, 2025
+901 −207

Conversation

JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Oct 17, 2025 •
edited
Loading

r? @jdonszelmann

Because:

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

JonathanBrouwer
JonathanBrouwer commented Oct 17, 2025
View reviewed changes
tests/ui/rfcs/rfc-2565-param-attrs/param-attrs-builtin-attrs.rs
//~^ ERROR documentation comments cannot be applied to function
#[must_use]
//~^ ERROR allow, cfg, cfg_attr, deny, expect, forbid, and warn are the only allowed built-in attributes in function parameters
//~| WARN attribute cannot be used on
Copy link
Contributor Author

@JonathanBrouwer JonathanBrouwer Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another duplicate warning, added to #147417, will fix in another PR

@jdonszelmann
Copy link
Contributor

r=me after you corrected that comment :)

@jdonszelmann
Copy link
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Oct 18, 2025 •
edited
Loading

@jdonszelmann This PR does not introduce the bug, it merely finds it. I think it's better to fix it in a separate PR, since the fix is sadly not trivial
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2025
@jdonszelmann
Copy link
Contributor

No I mean the unfinished comment, @rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2025
@JonathanBrouwer
Copy link
Contributor Author

Ah I see, I missed that oops :P
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

📌 Commit 8d68bd7 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2025
@JonathanBrouwer
Copy link
Contributor Author

@bors r=@jdonszelmann

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

📌 Commit 8d68bd7 has been approved by jdonszelmann

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2025
Merged
bors added a commit that referenced this pull request Oct 18, 2025
@bors
Auto merge of #147842 - matthiaskrgr:rollup-b4gp4p4, r=matthiaskrgr
6380899 
Rollup of 6 pull requests

Successful merges:

 - #146509 (Result/Option layout guarantee clarifications)
 - #147494 (std::thread spawn: Docs: Link to Builder::spawn; Make same.)
 - #147532 ( Port `#[cfg_attr]` to the new attribute parsing infrastructure)
 - #147783 (bootstrap: migrate to object 0.37)
 - #147792 (Fix autodiff incorrectly applying fat-lto to proc-macro crates )
 - #147809 (rustdoc: Fix passes order so intra-doc links are collected after stripping passes)

Failed merges:

 - #147813 (Warn on unused_attributes in uitests )

r? `@ghost`
`@rustbot` modify labels: rollup
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer
Copy link
Contributor Author

@bors r=@jdonszelmann
Rebased because of conflicts

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

📌 Commit 66b8a9d has been approved by jdonszelmann

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#147813 - JonathanBrouwer:unused_attributes,…
5f04bd1 
… r=jdonszelmann

Warn on unused_attributes in uitests

r? `@jdonszelmann`

Because:
- unused_attributes warnings are usually actual mistakes, rather than just unused code, and we want to notify test writers they may be accidentally making a mistake
- Because the lint was allowed by default previously, we missed real bugs, because the test coverage is worse
  1. rust-lang#147417
  2. rust-lang#147411
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2025
Closed
bors added a commit that referenced this pull request Oct 18, 2025
@bors
Auto merge of #147856 - matthiaskrgr:rollup-ksxc78w, r=matthiaskrgr
ec669eb 
Rollup of 8 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146167 (Deny-by-default never type lints)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2025
Merged
bors added a commit that referenced this pull request Oct 19, 2025
@bors
Auto merge of #147863 - matthiaskrgr:rollup-l4alyf0, r=matthiaskrgr
377a931 
Rollup of 7 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2d59f53 into rust-lang:master Oct 19, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 19, 2025
rust-timer added a commit that referenced this pull request Oct 19, 2025
@rust-timer
Unrolled build for #147813
903fe0d 
Rollup merge of #147813 - JonathanBrouwer:unused_attributes, r=jdonszelmann

Warn on unused_attributes in uitests

r? ```@jdonszelmann```

Because:
- unused_attributes warnings are usually actual mistakes, rather than just unused code, and we want to notify test writers they may be accidentally making a mistake
- Because the lint was allowed by default previously, we missed real bugs, because the test coverage is worse
  1. #147417
  2. #147411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @jdonszelmann @bors