-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Unify and deduplicate max recip float tests #147818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify and deduplicate max recip float tests #147818
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
r? tgross35 |
|
|
This comment has been minimized.
This comment has been minimized.
8e132eb to
401c80f
Compare
This comment has been minimized.
This comment has been minimized.
401c80f to
cd0dfd9
Compare
|
r? rust-lang/libs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd0dfd9 to
0c1b7f1
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready |
0c1b7f1 to
70876ee
Compare
|
Thank you! |
…float_tests, r=tgross35 Unify and deduplicate max recip float tests cc rust-lang#141726 This is a proposal to unify and deduplicate max recip tests for f16 and f128
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing cc63a0a (parent) -> e517798 (this PR) Test differencesShow 5 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e5177985a5493c783d6ba20960d2723d9d2e9214 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (e517798): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.029s -> 475.08s (0.01%) |
cc #141726
This is a proposal to unify and deduplicate max recip tests for f16 and f128