Skip to content

Conversation

@tshepang
Copy link
Member

The replaced id is for a pr that was later closed in favor of the new one

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member

Last time this happened, @Kobzol argued that fixing it wasn’t worth the churn, and should be deferred until another change-tracker entry is needed.

That was for an ID that was completely wrong; in this case the ID is merely suboptimal, so I’m inclined to give it the same treatment.

@Kobzol
Copy link
Member

Kobzol commented Oct 20, 2025

Yeah, I don't think this is super important, the closed PR has the right description, and that's the important thing. Changin the PR number now would cause more churn for people.

@jieyouxu
Copy link
Member

I'm going to close this PR for churn-avoidance purposes, thanks for the PR regardless.

@jieyouxu jieyouxu closed this Nov 12, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2025
@tshepang tshepang deleted the patch-3 branch November 13, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants