Rollup of 5 pull requests #149441

jhpratt · 2025-11-29T02:22:26Z

Successful merges:

Avoid suggesting constrain the associated type with unknown type #147362 (Avoid suggesting constrain the associated type with unknown type)
float::minimum/maximum: say which exact IEEE operation this corresponds to #149395 (float::minimum/maximum: say which exact IEEE operation this corresponds to)
Remove outdated comment #149396 (Remove outdated comment)
Add a regression test for issue 129865 #149421 (Add a regression test for issue 129865)
Update books #149424 (Update books)

r? @ghost
@rustbot modify labels: rollup

…ds to

…, r=fee1-dead Avoid suggesting constrain the associated type with unknown type Fixes rust-lang#147356

float::minimum/maximum: say which exact IEEE operation this corresponds to There's both `minimum` and `minimumNumber`, so this seems worth clarifying. Also use code font for these names to make it more clear that they are technical terms.

…ent, r=chenyukang Remove outdated comment The comment was added in rust-lang#136897 , but wasn't removed when the feature gate was stabilized (again). Also, `it's` -> `its` :)

…chenyukang Add a regression test for issue 129865 Closes rust-lang#129865 Looks like the previous versions (`< 1.85.0`) failed to normalize async block's upvar types containing constants but not anymore

Update books ## rust-lang/book 2 commits in f78ab89d7545ac17780e6a367055cc089f4cd2ec..8c0eacd5c4acbb650497454f3a58c9e8083202a4 2025-11-18 15:36:41 UTC to 2025-11-18 15:33:41 UTC - Update ch07-02-defining-modules-to-control-scope-and-privacy.md (rust-lang/book#4570) - use AND for search terms (rust-lang/book#4573) ## rust-lang/reference 4 commits in f9f1d2a4149f02582aec2f8fcdfa5b596193b4e2..f2ac173df9906de5c03b0ee50653321ef1c4ebe8 2025-11-26 02:52:23 UTC to 2025-11-18 21:54:51 UTC - document `cfg` conditions on inline assembly templates and operands (rust-lang/reference#2063) - remove unused "link reference definitions" (rust-lang/reference#2092) - Add review process overview to review-policy.md (rust-lang/reference#2088) - Remove restriction on dereferencing pointers in const (rust-lang/reference#2090) ## rust-lang/rust-by-example 5 commits in f944161716230641605b5e3733e1c81f10047fd4..111cfae2f9c3a43f7b0ff8fa68c51cc8f930637c 2025-11-27 20:16:42 UTC to 2025-11-20 21:40:02 UTC - Use `From::from` fn pointer to convert to boxed errors (rust-lang/rust-by-example#1906) - link the _tuple_ page instead "TupleStruct" (rust-lang/rust-by-example#1909) - enum_use.md: avoid an uncommon term (rust-lang/rust-by-example#1976) - make search less surprising (rust-lang/rust-by-example#1975) - Update documentation for `any` function in iter_any.md (rust-lang/rust-by-example#1973)

jhpratt · 2025-11-29T02:22:36Z

@bors r+ rollup=never p=5

bors · 2025-11-29T02:22:38Z

📌 Commit e838b66 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-11-29T05:20:10Z

⌛ Testing commit e838b66 with merge 3c5c558...

bors · 2025-11-29T08:29:49Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 3c5c558 to main...

rust-timer · 2025-11-29T08:31:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147362	Avoid suggesting constrain the associated type with unknown…	`0dbcf7d8e3e44008466b209031bd566b091ffa56` (link)
#149395	float::minimum/maximum: say which exact IEEE operation this…	`96d34ac4b72e7ad1196a4bbb74b85c981bc43886` (link)
#149396	Remove outdated comment	`7be7fd82dcc094d3320a17b07b32be7eb32fd446` (link)
#149421	Add a regression test for issue 129865	`64b5499f386ba25b2cc4ef94607f642f8670c582` (link)
#149424	Update books	`d34a235820e17c8919c874f5251e02e9d7dffee7` (link)

previous master: 467250ddb2

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-29T08:32:28Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 467250d (parent) -> 3c5c558 (this PR)

Test differences

Show 4 test diffs

Stage 1

[ui] tests/ui/traits/associated_type_bound/assoc-type-maybe-trait-147356.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/next-solver/normalize/normalize-const-in-async-body.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/traits/associated_type_bound/assoc-type-maybe-trait-147356.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/next-solver/normalize/normalize-const-in-async-body.rs: [missing] -> pass (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3c5c55864f8f441054730037bc9f9901f9151398 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 8441.8s -> 5731.1s (-32.1%)
dist-aarch64-msvc: 5332.3s -> 6726.7s (+26.2%)
x86_64-gnu-llvm-21-3: 6692.2s -> 5571.7s (-16.7%)
x86_64-gnu-llvm-21-1: 3405.7s -> 2934.5s (-13.8%)
x86_64-gnu-llvm-20-2: 5936.4s -> 5136.4s (-13.5%)
aarch64-gnu-llvm-20-1: 3877.7s -> 3369.4s (-13.1%)
aarch64-gnu-debug: 4381.6s -> 3823.3s (-12.7%)
x86_64-gnu-gcc: 3431.0s -> 3001.6s (-12.5%)
pr-check-2: 2554.1s -> 2234.9s (-12.5%)
pr-check-1: 1867.6s -> 1634.6s (-12.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-29T09:50:09Z

Finished benchmarking commit (3c5c558): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.687s -> 469.399s (-0.91%)
Artifact size: 386.86 MiB -> 386.89 MiB (0.01%)

chenyukang and others added 10 commits November 22, 2025 10:20

Avoid suggesting constrain the associated type to a trait

76bd555

float::minimum/maximum: say which exact IEEE operation this correspon…

be22161

…ds to

Remove outdated comment

f15e99b

Add a regression test for issue 129865

c6b0f78

Update books

d2564a9

Rollup merge of rust-lang#147362 - chenyukang:yukang-fix-bound-147356…

888e5da

…, r=fee1-dead Avoid suggesting constrain the associated type with unknown type Fixes rust-lang#147356

Rollup merge of rust-lang#149396 - yotamofek:pr/library/outdated-comm…

a3173c1

…ent, r=chenyukang Remove outdated comment The comment was added in rust-lang#136897 , but wasn't removed when the feature gate was stabilized (again). Also, `it's` -> `its` :)

Rollup merge of rust-lang#149421 - ShoyuVanilla:regression-129865, r=…

0b94bc0

…chenyukang Add a regression test for issue 129865 Closes rust-lang#129865 Looks like the previous versions (`< 1.85.0`) failed to normalize async block's upvar types containing constants but not anymore

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 29, 2025

bors merged commit 3c5c558 into rust-lang:main Nov 29, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 29, 2025

jhpratt deleted the rollup-4hmqc0z branch November 29, 2025 08:30

bors mentioned this pull request Nov 29, 2025

Add Drop::pin_drop for pinned drops #144537

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #149441

Rollup of 5 pull requests #149441

jhpratt commented Nov 29, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Nov 29, 2025

Uh oh!

bors commented Nov 29, 2025

Uh oh!

bors commented Nov 29, 2025

Uh oh!

bors commented Nov 29, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 29, 2025

Uh oh!

github-actions bot commented Nov 29, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Rollup of 5 pull requests #149441

Rollup of 5 pull requests #149441

Conversation

jhpratt commented Nov 29, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Nov 29, 2025

Uh oh!

bors commented Nov 29, 2025

Uh oh!

bors commented Nov 29, 2025

Uh oh!

bors commented Nov 29, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 29, 2025

Uh oh!

github-actions bot commented Nov 29, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 29, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jhpratt commented Nov 29, 2025 •

edited by rustbot

Loading