Skip to content

Dist Enzyme for macOS with unversioned LLVM dylib#151063

Draft
sgasho wants to merge 6 commits intorust-lang:mainfrom
sgasho:aarch64-dist-enzyme
Draft

Dist Enzyme for macOS with unversioned LLVM dylib#151063
sgasho wants to merge 6 commits intorust-lang:mainfrom
sgasho:aarch64-dist-enzyme

Conversation

@sgasho
Copy link
Contributor

@sgasho sgasho commented Jan 13, 2026 •
edited
Loading

View all comments

Follow-up to #152768.

  • Link LLVM dynamically on MacOS
  • Fix a macOS LLVM dylib name mismatch
  • Dist Enzyme for MacOS

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 13, 2026
@sgasho sgasho mentioned this pull request Jan 13, 2026
Open
@sgasho sgasho changed the title Add dist step for enzyme including aarch64-apple-darwin Add dist step for enzyme, including aarch64-apple-darwin Jan 13, 2026
@ZuseZ4
Copy link
Member

ZuseZ4 commented Jan 13, 2026

@bors delegate try

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

Unknown command "delegate". Run @bors help to see available commands.

@ZuseZ4
Copy link
Member

ZuseZ4 commented Jan 13, 2026

Hmm, not sure about the exact syntax, but delegate itself should have been recognized, maybe not ported to the new bots yet? I'll let Jakub handle it.
For now

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
a658070 
Add dist step for enzyme, including aarch64-apple-darwin


try-job: dist-aarch64-apple
@Kobzol
Copy link
Member

Kobzol commented Jan 13, 2026

@bors delegate=try

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

✌️ @sgasho, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

@Kobzol Kobzol mentioned this pull request Jan 13, 2026
Merged
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

☀️ Try build successful (CI)
Build commit: a658070 (a65807068ca7fef2605b24756206b9e5dfa49bbd, parent: db1484bdee1cb065b322a5bd512b39c49dadc9e5)

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 14, 2026

☔ The latest upstream changes (presumably #150541) made this pull request unmergeable. Please resolve the merge conflicts.

@sgasho
Copy link
Contributor Author

sgasho commented Jan 17, 2026

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
@sgasho sgasho force-pushed the aarch64-dist-enzyme branch from 30f87bc to 31d3fde Compare January 17, 2026 03:41
@sgasho
Copy link
Contributor Author

sgasho commented Jan 17, 2026

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 17, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
6791d6a 
Add dist step for enzyme, including aarch64-apple-darwin


try-job: dist-aarch64-apple
@rustbot rustbot added the F-autodiff `#![feature(autodiff)]` label Jan 17, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@sgasho sgasho force-pushed the aarch64-dist-enzyme branch from bc7b483 to 98144d4 Compare January 17, 2026 07:21
@sgasho
Copy link
Contributor Author

sgasho commented Jan 17, 2026

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 17, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
2c9be7e 
Add dist step for enzyme, including aarch64-apple-darwin


try-job: dist-aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 17, 2026

💔 Test for 2c9be7e failed: CI. Failed job:

rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
d9e7df3 
Dist Enzyme for macOS with unversioned LLVM dylib


try-job: dist-aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 9, 2026

💔 Test for d9e7df3 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@sgasho
Copy link
Contributor Author

sgasho commented Mar 10, 2026

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
aac8c8c 
Dist Enzyme for macOS with unversioned LLVM dylib


try-job: dist-aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 10, 2026

💔 Test for aac8c8c failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@sgasho
Copy link
Contributor Author

sgasho commented Mar 11, 2026

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 11, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
3b095cd 
Dist Enzyme for macOS with unversioned LLVM dylib


try-job: dist-aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 11, 2026

☀️ Try build successful (CI)
Build commit: 3b095cd (3b095cd12ab6130fe5fbd49bcab8e6c103bea4d5, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@sgasho
Copy link
Contributor Author

sgasho commented Mar 12, 2026

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 12, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
561afc8 
Dist Enzyme for macOS with unversioned LLVM dylib


try-job: dist-aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 12, 2026

☀️ Try build successful (CI)
Build commit: 561afc8 (561afc87d6765aff4217534c293cbc2990425de0, parent: d097a0cba9a42f8e37bd28d0d219e433938981ec)

@sgasho
Copy link
Contributor Author

sgasho commented Mar 15, 2026

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 15, 2026
@bors
Auto merge of #151063 - sgasho:aarch64-dist-enzyme, r=<try>
99e2a89 
Dist Enzyme for macOS with unversioned LLVM dylib


try-job: dist-aarch64-apple
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 15, 2026

☀️ Try build successful (CI)
Build commit: 99e2a89 (99e2a898c1d8463abd8f9fcc03f162d20deb0286, parent: 9f0615c4301206eeba76468f78d34876c4a2997e)

@ZuseZ4
Copy link
Member

ZuseZ4 commented Mar 16, 2026

(please feel free to ping Ralf jung whenever you think you have an artifact that you think should work for them)

@sgasho
Copy link
Contributor Author

sgasho commented Mar 16, 2026

@RalfJung
related: #153077 (comment)
Could you check if Miri builds successfully using the artifact below?

https://github.com/rust-lang/rust/actions/runs/23104042131

@RalfJung RalfJung mentioned this pull request Mar 16, 2026
Closed
@ZuseZ4
Copy link
Member

ZuseZ4 commented Mar 16, 2026 •
edited
Loading

Nice, it seems like Miri passed.

Can you please run some (or all if not too slow) of the UI or pretty tests a few times under the old and new tool chain? I'd expect a diff to be more noise than anything based on what was discussed previously, but we should confirm that the diff isn't too big. Just post all times, but the minimal times are likely the most relevant ones.

@RalfJung
Copy link
Member

RalfJung commented Mar 16, 2026

Yeah looks like linking with rustc_driver still works, nice.

There were I think some other concerns about dynamic linking, Cc @bjorn3 @madsmtm

bjorn3
bjorn3 reviewed Mar 16, 2026
View reviewed changes
compiler/rustc_metadata/src/native_libs.rs
@@ -72,7 +75,8 @@ pub fn walk_native_lib_search_dirs<R>(
|| sess.target.os == Os::Linux
Copy link
Member

@bjorn3 bjorn3 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above needs to be updated with an explanation for why we also do this for macOS+libLLVM.dylib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc F-autodiff `#![feature(autodiff)]` S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sgasho @ZuseZ4 @Kobzol @rust-log-analyzer @RalfJung @bjorn3 @rustbot