Skip to content

fix undefined behavior in VecDeque::splice #151769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Qelxiros wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix undefined behavior in VecDeque::splice #151769

Qelxiros wants to merge 1 commit into from
+16 −1

Conversation

@Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Jan 28, 2026 •
edited by rustbot
Loading

closes #151758

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 28, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet
Copy link
Member

joboet commented Jan 28, 2026

Ugh, that's not good... we should probably enforce the distinction between physical and logical indices through the type system, or at least document what is expected for each function.

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

📌 Commit b0d9649 has been approved by joboet

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 28, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151769 - Qelxiros:vecdeque_splice_fix, r=jo…
3ffbf6e 
…boet

fix undefined behavior in VecDeque::splice

closes rust-lang#151758
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 28, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Jan 28, 2026
@bors
Auto merge of #151794 - JonathanBrouwer:rollup-rGbYGX2, r=JonathanBro…
ba284f4 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #150491 (resolve: Mark items under exported ambiguous imports as exported)
 - #150720 (Do not suggest `derive` if there is already an impl)
 - #150968 (compiler-builtins: Remove the no-f16-f128 feature)
 - #151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain")
 - #151660 (Bump `std`'s `backtrace`'s `rustc-demangle`)
 - #151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting)
 - #151704 (Implement `set_output_kind` for Emscripten linker)
 - #151706 (Remove Fuchsia from target OS list in unix.rs for sleep)
 - #151769 (fix undefined behavior in VecDeque::splice)
 - #151779 (stdarch subtree update)
 - #151449 ([rustdoc] Add regression test for #151411)
 - #151773 (clean up checks for constant promotion of integer division/remainder operations)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new VecDeque::splice() method in nightly produce incorrect result

3 participants

@Qelxiros @rustbot @joboet