Skip to content

Conversation

@Zalathar
Copy link
Member

Tiny PR to fix some typos I stumbled across.

No functional changes.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 28, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 28, 2026

want to add this to our typos config so it gets caught by the CI check?

@Zalathar
Copy link
Member Author

I was planning to, but from looking at the config I couldn’t figure out how.

Is there an example somewhere I can look at?

@rust-log-analyzer

This comment has been minimized.

@lqd
Copy link
Member

lqd commented Jan 28, 2026

I was planning to, but from looking at the config I couldn’t figure out how.

IIUC it should be adding something like

definitinon = "definition"

to the [default.extend-words] section of typos.toml

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Zalathar
Copy link
Member Author

Ah, the comments in typos.toml are very confusing, because the same table is used to blocklist specific bad words, and to allowlist specific good words, with near-identical syntax (because they're typos!)

So from what I can tell:

  • mispel = "mispel" adds mispel to the allowlist
  • mispel = "" adds mispel to the blocklist
  • mispel = "misspell" adds mispel to the blocklist, with an auto-fix of misspell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants