Suggest : when ; is used before a macro_rules! fragment specifier#153843
Open
ozankenangungor wants to merge 2 commits intorust-lang:mainfrom
Open
Suggest : when ; is used before a macro_rules! fragment specifier#153843ozankenangungor wants to merge 2 commits intorust-lang:mainfrom
: when ; is used before a macro_rules! fragment specifier#153843ozankenangungor wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Mar 14, 2026
| result.push(TokenTree::MetaVarDecl { | ||
| span: start_sp, | ||
| name: ident, | ||
| kind: NonterminalKind::TT, |
Member
There was a problem hiding this comment.
You could use the nonterminal kind here that you've already parsed above but are currently discarding.
That way, you'd recover $x;ty as $x:ty instead of $x:tt.
Kivooeo
reviewed
Mar 14, 2026
Comment on lines
+9
to
+12
| help: try adding a specifier here | ||
| | | ||
| LL | ($x:spec;tt) => {}; | ||
| | +++++ |
Member
There was a problem hiding this comment.
haven't looked thought, but is that possible to remove this missleading help?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153320
Add a suggestion for the typo case where
;is used instead of:before a validmacro_rules!fragment specifier.This leaves the existing
missing fragment specifierdiagnostic as-is and only adds an extra suggestion for the$x;fragmentcase.