refactor: shrink check_attr by moving attribute checks to parsers#153845
Draft
herbenderbler wants to merge 1 commit intorust-lang:mainfrom
Draft
refactor: shrink check_attr by moving attribute checks to parsers#153845herbenderbler wants to merge 1 commit intorust-lang:mainfrom
herbenderbler wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-attributes
herbenderbler
force-pushed
the
ISSUE-153101/shrink-check-attrs
branch
2 times, most recently
from
7d4cf51 to
b5ad742
Compare
This comment has been minimized.
This comment has been minimized.
Move check_custom_mir validation into rustc_attr_parsing (CustomMirParser). Introduce late_validation with LateValidationContext and validators for: - #[deprecated], #[loop_match], #[const_continue] - diagnostic::on_unimplemented, diagnostic::on_const, diagnostic::do_not_recommend - #[link], #[macro_export] Remove duplicated check_* logic from check_attr pass. Fix crate-root ICE (opt_local_parent), CustomMir types, and directive/impl target handling. Part of rust-lang#153101. Made-with: Cursor
herbenderbler
force-pushed
the
ISSUE-153101/shrink-check-attrs
branch
from
b5ad742 to
1717ac5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move check_custom_mir validation into rustc_attr_parsing (CustomMirParser).
Introduce late_validation with LateValidationContext and validators for:
Remove duplicated check_* logic from check_attr pass. Fix crate-root ICE
(opt_local_parent), CustomMir types, and directive/impl target handling.
Part of #153101.