Skip to content

Rename cycle_check to find_cycle#153862

Open
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:cycle-check-rename
Open

Rename cycle_check to find_cycle#153862
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:cycle-check-rename

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 14, 2026

This renames cycle_check to find_cycle as that fits a bit better.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2026

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, query-system
  • compiler, query-system expanded to 69 candidates
  • Random selection from 15 candidates

@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 14, 2026

cc @nnethercote

@chenyukang
Copy link
Member

chenyukang commented Mar 14, 2026

r me when CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyukang chenyukang chenyukang approved these changes

Assignees

@chenyukang chenyukang

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zoxc @rustbot @chenyukang