Conversation
|
rustbot has assigned @jdonszelmann. Use Why was this reviewer chosen?The reviewer was selected based on:
|
There was a problem hiding this comment.
Hmm, though I agree that these tests are trivial, and that most likely there are a thousand other tests that test similar behavior, I'm against removing them. When a complicated change breaks something, it's often nice for look for the simplest possible test that reproduces it. It's the closest thing we have to unit tests in our ui suite, which otherwise is much more like an integration test.
|
Reminder, once the PR becomes ready for a review, use |
|
I think that any change that would cause one of these tests to break would also make it impossible for you to even compile |
None of these test for anything interesting as far as I see.