Skip to content

delete some super-trivial tests#153868

Open
cyrgani wants to merge 1 commit intorust-lang:mainfrom
cyrgani:del-trivial
Open

delete some super-trivial tests#153868
cyrgani wants to merge 1 commit intorust-lang:mainfrom
cyrgani:del-trivial

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Mar 14, 2026

None of these test for anything interesting as far as I see.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2026

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

Copy link
Contributor

@jdonszelmann jdonszelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, though I agree that these tests are trivial, and that most likely there are a thousand other tests that test similar behavior, I'm against removing them. When a complicated change breaks something, it's often nice for look for the simplest possible test that reproduces it. It's the closest thing we have to unit tests in our ui suite, which otherwise is much more like an integration test.

View changes since this review

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 14, 2026
@cyrgani
Copy link
Contributor Author

cyrgani commented Mar 14, 2026

I think that any change that would cause one of these tests to break would also make it impossible for you to even compile core or std, so you wouldn't be able to get to the point where you could run these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants