Skip to content

docs: remove stale reference to check_let_chain#153870

Open
Misaka299 wants to merge 1 commit intorust-lang:mainfrom
Misaka299:fix-stale-comment-check-match
Open

docs: remove stale reference to check_let_chain#153870
Misaka299 wants to merge 1 commit intorust-lang:mainfrom
Misaka299:fix-stale-comment-check-match

Conversation

@Misaka299
Copy link

@Misaka299 Misaka299 commented Mar 14, 2026

This PR removes a stale reference to check_let_chain in the documentation of compiler/rustc_mir_build/src/thir/pattern/check_match.rs, as the function was previously removed in #146832.

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2026

Some changes occurred in match checking

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2026

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

@rustbot

This comment has been minimized.

@Kivooeo
Copy link
Member

Kivooeo commented Mar 14, 2026

Hi, please consider removing issue link from commit message as suggest message above, thanks!

@Kivooeo Kivooeo assigned Kivooeo and unassigned dingxiangfei2009 Mar 14, 2026
@rustbot

This comment has been minimized.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 15, 2026
@Misaka299 Misaka299 force-pushed the fix-stale-comment-check-match branch from 9d91224 to e66675d Compare March 15, 2026 05:07
@rustbot

This comment has been minimized.

@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Mar 15, 2026
The function `check_let_chain` was removed previously, but it was still
referenced in a comment in `check_match.rs`. This commit cleans it up.
@Misaka299 Misaka299 force-pushed the fix-stale-comment-check-match branch from e66675d to 50d4943 Compare March 15, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants