tests/debuginfo/basic-stepping.rs: Remove ignore-aarch64#153877
tests/debuginfo/basic-stepping.rs: Remove ignore-aarch64#153877rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
d583583 to
a27fdfb
Compare
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors rollup=iffy (see PR description) |
|
Looks like we have an empty queue ATM. @bors r+ rollup=never |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e0a8361 (parent) -> 79d2026 (this PR) Test differencesShow 8 test diffsStage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 79d2026ae87386ccbe8fc729d130e5e298959a48 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (79d2026): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 480.839s -> 481.027s (0.04%) |
|
This test failed in a later PR at #153935 (comment), so I'm worried that the test might be flaky. |
|
Looks like that failure was because the process terminated while we were stepping through the code : Not sure what to make of it. If the flakiness remains, we should probably not do a full revert, but instead just ignore aarch64-windows. I'll try to prepare a PR for that, so we have one ready if needed. Edit: |
This test passes for me both with
gdbandlldbwhen I run it on an aarch64 machine (namely dev-desktop-eu-1).And as can be seen below, it now passes PR CI, including aarch64-gnu-llvm-21-1.
This test used to fail PR CI, in particular aarch64-gnu-llvm-19-1.
I suggest we put this in a rollup as an iffy PR to see if we can get it through. If we can, we are one step closer towards closing #33013.