Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests#153880
Open
asder8215 wants to merge 2 commits intorust-lang:mainfrom
Open
Lifted intersperse and intersperse_with Fused transformation and updated documentation + tests#153880asder8215 wants to merge 2 commits intorust-lang:mainfrom
asder8215 wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
Contributor
Author
|
Oh didn't realize jhpratt is off rotation. Then, r? libs |
This comment has been minimized.
This comment has been minimized.
asder8215
force-pushed
the
intersperse_nonfused
branch
from
3d90677 to
8361a97
Compare
…d documentation + tests
asder8215
force-pushed
the
intersperse_nonfused
branch
from
8361a97 to
800d9ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR once again builds on top of #152855. From the discussion in #152855, libs team came to the conclusion that
intersperse/intersperse_withshouldn't transform the given iterator to a fused iterator always and a separator should be emitted betweenSome(_)items for non fused iterators (particularly just right before the subsequentSome(_)).On top of the change Zakarumych added in the PR, I lifted the
FusedIteratortrait and transformation of the inneriterforIntersperse/IntersperseWith, so that we can display this behavior. I've adjusted the documentation and tests accordingly to reflect this change as well.r? @jhpratt