Handle error types gracefully in cat_deref

[ViewWay]

Fixes #153733.

When type resolution fails (e.g., due to combining unstable features like pin_ergonomics with min_generic_const_args), structurally_resolve_type returns an error type.

When builtin_deref is called on this error type, it returns None, causing the code to panic with "explicit deref of non-derefable type".

The fix checks if the resolved type contains an error using error_reported_in_ty and returns early if so, allowing compilation to continue and report the actual error instead of ICE-ing.

[rustbot]

HIR ty lowering was modified

cc @fmease

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

[rustbot]

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 69 candidates
• Random selection from 15 candidates

[rustbot]

⚠️ Warning ⚠️

• There are issue links (such as #123) in the commit messages of the following commits.
  Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
  • cd499ee

[rust-log-analyzer]

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING:end] tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
Diff in /checkout/compiler/rustc_hir_typeck/src/expr_use_visitor.rs:1513:
         let resolved_ty = self
             .cx
             .structurally_resolve_type(self.cx.tcx().hir_span(base_place.hir_id), base_curr_ty);
-        
+
         // If the type is an error (e.g., from prior inference failure), return early
         self.cx.error_reported_in_ty(resolved_ty)?;
-        
+
         let Some(deref_ty) = resolved_ty.builtin_deref(true) else {
             debug!("explicit deref of non-derefable type: {:?}", base_curr_ty);
             return Err(self
fmt: checked 6743 files
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:00:49
  local time: Sun Mar 15 04:35:28 UTC 2026
  network time: Sun, 15 Mar 2026 04:35:28 GMT

[fmease]

For the love of god, please drop your cherry-pick of the commit I authored in open PR RUST-153738. It makes no sense whatsoever to take ownership of it & to include it here and in your ~5 other PRs. Your PRs can't proceed otherwise.

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.