Skip to content

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Nov 21, 2019

Cherry-picked from #60900.

As requested by @Centril (and @nikomatsakis, I believe).

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2019
@bors

This comment has been minimized.

@Centril
Copy link
Contributor

Centril commented Nov 21, 2019

Thanks; r=me with comments ^--- addressed.

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2019
@Centril
Copy link
Contributor

Centril commented Nov 21, 2019

Fairly bit-rotty; @bors p=1

@alexreg
Copy link
Contributor Author

alexreg commented Nov 21, 2019

@bors r=Centril p=1

@bors
Copy link
Collaborator

bors commented Nov 21, 2019

📌 Commit 1b2de17 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2019
@bors
Copy link
Collaborator

bors commented Nov 21, 2019

⌛ Testing commit 1b2de17 with merge f11759d...

bors added a commit that referenced this pull request Nov 21, 2019
Aggregation of drive-by cosmetic changes for trait-upcasting PR

Cherry-picked from #60900.

As requested by @Centril (and @nikomatsakis, I believe).

r? @Centril
@bors
Copy link
Collaborator

bors commented Nov 22, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing f11759d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2019
@bors bors merged commit 1b2de17 into rust-lang:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants