Skip to content

De-abuse TyKind::Error in exhaustiveness checking #71930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 21, 2020
Merged

De-abuse TyKind::Error in exhaustiveness checking #71930

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e65d49d
Fix incorrect ordering
Nadrieril May 6, 2020
4a1772e
Factor the code that generates TyErrs
Nadrieril Apr 13, 2020
a5294b6
We already handle arrays of unknown length correctly
Nadrieril Apr 13, 2020
160eebe
Only need TyErr for uninhabited types
Nadrieril Apr 13, 2020
76dea86
Factor out a struct that holds subfields of a pattern
Nadrieril May 9, 2020
3551f1a
Use Fields as output to specialize_one_pattern
Nadrieril May 9, 2020
c3d3727
Clarify specialize_one_pattern
Nadrieril May 9, 2020
70b3872
Make all field-handling go through Fields
Nadrieril May 9, 2020
59fa40a
Filter out fields that should not be seen
Nadrieril May 9, 2020
8f08b16
Small allocation improvement
Nadrieril May 9, 2020
e5a2cd5
We don't use tyerr anymore
Nadrieril May 9, 2020
079400c
Fix bug just discovered
Nadrieril May 9, 2020
4f7a378
typo
Nadrieril May 9, 2020
aff073e
Cache len in Fields
Nadrieril May 17, 2020
c6f0947
Improve comments
Nadrieril May 17, 2020
4c6510b
Typo
Nadrieril May 18, 2020
159f48c
Don't mention function pointers
Nadrieril May 18, 2020
d7e1d5f
Make caveat more precise
Nadrieril May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/librustc_mir_build/hair/pattern/_match.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@
/// (`Constructor`, `Fields`) pairs, handling all the special cases correctly.
///
/// Caveat: this constructors/fields distinction doesn't quite cover every Rust value. For example
/// a value of type `Rc<u64>` doesn't fit this idea very well, nor do function pointers and various
/// other things. However, the idea covers everything that can be pattern-matched, and this is all
/// we need for exhaustiveness checking.
/// a value of type `Rc<u64>` doesn't fit this idea very well, nor do various other things.
/// However, this idea covers everything that can be pattern-matched, and this is all we need for
/// exhaustiveness checking.
///
///
/// # Algorithm
Expand Down