Skip to content

Conversation

pickfire
Copy link
Contributor

r? @GuillaumeGomez

Follow up of #76489

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2020
}
#[ffi_pure]
extern "C" pub fn foo() {} // ok!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what it's adding. :-/

Copy link
Contributor Author

@pickfire pickfire Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative extern syntax I mentioned last time. I didn't know about extern "C" { ... } before this but I only know extern "C" ..., one thing is to let others know that extern could be not a block. But there's a typo here, should be ffi_const.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, it doesn't work. I thought it works.

@pickfire pickfire closed this Sep 22, 2020
@pickfire pickfire deleted the patch-5 branch September 22, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants