Skip to content

Conversation

pickfire
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2020
@pickfire
Copy link
Contributor Author

r? @Mark-Simulacrum

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you have a bunch of improvements like this I would personally prefer to see a single PR rather than tiny PRs, easier to review in batches. (And less commits editing docs, better git history, etc.)

@pickfire
Copy link
Contributor Author

pickfire commented Sep 25, 2020

I think if you have a bunch of improvements like this I would personally prefer to see a single PR rather than tiny PRs, easier to review in batches. (And less commits editing docs, better git history, etc.)

Not exactly, I just send these sort of PR once I found it, I don't find it all at once since it is scattered everywhere.

But yeah, I have another batch of PR on vec bench but I didn't send it in batch since it is easier to just change the file in github and let others review one by one. But I also don't want to remove a commit if one of the change is not good so I just send it one by one. See #77185 for one of them.

But yeah these (this one) PRs are ad-hoc, only those that I ping myself are in batch.

@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Oct 1, 2020

@Mark-Simulacrum Can I create a new pull request for it? I am lazy to rebase.

@Mark-Simulacrum
Copy link
Member

I am unopposed.

@pickfire pickfire closed this Oct 1, 2020
@pickfire pickfire deleted the patch-6 branch October 1, 2020 02:07
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2020
Fix typo in vec doc "tries to reserves"

Superseeds rust-lang#77192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants