Skip to content

Fix rustdoc --test-builder argument parsing #80924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Fix rustdoc --test-builder argument parsing #80924

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b18a426
Fix rustdoc --test-builder argument parsing
teryror Jan 11, 2021
0401a99
Update help message and add regression test
teryror Jan 12, 2021
f3c8f29
Simplify regression test
teryror Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/librustdoc/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,11 +412,7 @@ fn opts() -> Vec<RustcOptGroup> {
)
}),
unstable("test-builder", |o| {
o.optflag(
"",
"test-builder",
"specified the rustc-like binary to use as the test builder",
)
o.optopt("", "test-builder", "The rustc-like binary to use as the test builder", "PATH")
}),
unstable("check", |o| o.optflag("", "check", "Run rustdoc checks")),
]
Expand Down
7 changes: 7 additions & 0 deletions src/test/rustdoc/issue-80893.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// compile-flags: --test -Z unstable-options --test-builder true --runtool true

/// ```
/// This does not compile, but specifying a custom --test-builder should let this pass anyway
/// `true` does not generate an output file to run, so we also specify it as a runtool
/// ```
pub struct Foo;