Revert reverting of stabilizing integer::BITS. #82565

m-ou-se · 2021-02-26T21:42:53Z

Now that lexical-core has an updated version that won't break with this stabilization, let's try to stabilize this again.

See #81654 (comment)

Tracking issue with FCP: #76904

rust-highfive · 2021-02-26T21:42:56Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

kennytm · 2021-02-27T07:45:20Z

@bors try

bors · 2021-02-27T07:45:32Z

⌛ Trying commit a786f403e3e09bc9bda8f98a7e465ea95d2a451c with merge 8e3afc79c11f48cb3acd1be5b3b7de98fe3f93a8...

bors · 2021-02-27T08:34:26Z

☀️ Try build successful - checks-actions
Build commit: 8e3afc79c11f48cb3acd1be5b3b7de98fe3f93a8 (8e3afc79c11f48cb3acd1be5b3b7de98fe3f93a8)

kennytm · 2021-02-27T16:42:36Z

@craterbot check

craterbot · 2021-02-27T16:42:40Z

👌 Experiment pr-82565 created and queued.
🤖 Automatically detected try build 8e3afc79c11f48cb3acd1be5b3b7de98fe3f93a8
⚠️ Try build based on commit 9fa580b, but latest commit is a786f403e3e09bc9bda8f98a7e465ea95d2a451c. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-03-13T22:03:52Z

🚧 Experiment pr-82565 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Muximize · 2021-03-19T11:03:32Z

It looks like Crater got stuck 😕

m-ou-se · 2021-03-21T22:31:39Z

It looks like Crater got stuck

@rust-lang/infra ^

craterbot · 2021-03-23T18:31:40Z

🎉 Experiment pr-82565 is completed!
📊 1568 regressed and 15 fixed (147991 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

kennytm · 2021-03-23T19:32:11Z

lexical-core ≤0.7.4 should be the only non-spurious breakage. This has already been fixed in the latest 0.7.5 by Alexhuszagh/rust-lexical#56.

[INFO] [stdout] error[E0308]: mismatched types
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/github.com-1ecc6299db9ec823/lexical-core-0.4.0/src/atof/algorithm/bigcomp.rs:246:55
[INFO] [stdout]     |
[INFO] [stdout] 246 |     let nlz = den.leading_zeros().wrapping_sub(wlz) & (u32::BITS - 1);
[INFO] [stdout]     |                                                       ^^^^^^^^^^^^^^^ expected `usize`, found `u32`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error[E0277]: no implementation for `usize & u32`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/github.com-1ecc6299db9ec823/lexical-core-0.4.0/src/atof/algorithm/bigcomp.rs:246:53
[INFO] [stdout]     |
[INFO] [stdout] 246 |     let nlz = den.leading_zeros().wrapping_sub(wlz) & (u32::BITS - 1);
[INFO] [stdout]     |                                                     ^ no implementation for `usize & u32`
[INFO] [stdout]     |
[INFO] [stdout]     = help: the trait `BitAnd<u32>` is not implemented for `usize`

r=me if this is good to go.

m-ou-se · 2021-03-24T21:57:41Z

@bors r=kennytm

bors · 2021-03-24T21:57:42Z

📌 Commit bacd522 has been approved by kennytm

bors · 2021-03-25T10:30:02Z

⌛ Testing commit bacd522 with merge bba4088...

bors · 2021-03-25T13:11:12Z

☀️ Test successful - checks-actions
Approved by: kennytm
Pushing bba4088 to master...

Pkgsrc changes: * Bump bootstrap requirements to 1.52.1 * Adjust patches, adapt to upstream changes, adjust cargo checksums * If using an external llvm, require >= 10.0 Upsteream changes: Version 1.53.0 (2021-06-17) ============================ Language ----------------------- - [You can now use unicode for identifiers.][83799] This allows multilingual identifiers but still doesn't allow glyphs that are not considered characters such as `#` (diamond) or `<U+1F980>` (crab). More specifically you can now use any identifier that matches the UAX #31 "Unicode Identifier and Pattern Syntax" standard. This is the same standard as languages like Python, however Rust uses NFC normalization which may be different from other languages. - [You can now specify "or patterns" inside pattern matches.][79278] Previously you could only use `|` (OR) on complete patterns. E.g. ```rust let x = Some(2u8); // Before matches!(x, Some(1) | Some(2)); // Now matches!(x, Some(1 | 2)); ``` - [Added the `:pat_param` `macro_rules!` matcher.][83386] This matcher has the same semantics as the `:pat` matcher. This is to allow `:pat` to change semantics to being a pattern fragment in a future edition. Compiler ----------------------- - [Updated the minimum external LLVM version to LLVM 10.][83387] - [Added Tier 3\* support for the `wasm64-unknown-unknown` target.][80525] - [Improved debuginfo for closures and async functions on Windows MSVC.][83941] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries ----------------------- - [Abort messages will now forward to `android_set_abort_message` on Android platforms when available.][81469] - [`slice::IterMut<'_, T>` now implements `AsRef<[T]>`][82771] - [Arrays of any length now implement `IntoIterator`.][84147] Currently calling `.into_iter()` as a method on an array will return `impl Iterator<Item=&T>`, but this may change in a future edition to change `Item` to `T`. Calling `IntoIterator::into_iter` directly on arrays will provide `impl Iterator<Item=T>` as expected. - [`leading_zeros`, and `trailing_zeros` are now available on all `NonZero` integer types.][84082] - [`{f32, f64}::from_str` now parse and print special values (`NaN`, `-0`) according to IEEE RFC 754.][78618] - [You can now index into slices using `(Bound<usize>, Bound<usize>)`.][77704] - [Add the `BITS` associated constant to all numeric types.][82565] Stabilised APIs --------------- - [`AtomicBool::fetch_update`] - [`AtomicPtr::fetch_update`] - [`BTreeMap::retain`] - [`BTreeSet::retain`] - [`BufReader::seek_relative`] - [`DebugStruct::non_exhaustive`] - [`Duration::MAX`] - [`Duration::ZERO`] - [`Duration::is_zero`] - [`Duration::saturating_add`] - [`Duration::saturating_mul`] - [`Duration::saturating_sub`] - [`ErrorKind::Unsupported`] - [`Option::insert`] - [`Ordering::is_eq`] - [`Ordering::is_ge`] - [`Ordering::is_gt`] - [`Ordering::is_le`] - [`Ordering::is_lt`] - [`Ordering::is_ne`] - [`OsStr::is_ascii`] - [`OsStr::make_ascii_lowercase`] - [`OsStr::make_ascii_uppercase`] - [`OsStr::to_ascii_lowercase`] - [`OsStr::to_ascii_uppercase`] - [`Peekable::peek_mut`] - [`Rc::decrement_strong_count`] - [`Rc::increment_strong_count`] - [`Vec::extend_from_within`] - [`array::from_mut`] - [`array::from_ref`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`cmp::max_by_key`] - [`cmp::max_by`] - [`cmp::min_by_key`] - [`cmp::min_by`] - [`f32::is_subnormal`] - [`f64::is_subnormal`] Cargo ----------------------- - [Cargo now supports git repositories where the default `HEAD` branch is not "master".][cargo/9392] This also includes a switch to the version 3 `Cargo.lock` format which can handle default branches correctly. - [macOS targets now default to `unpacked` split-debuginfo.][cargo/9298] - [The `authors` field is no longer included in `Cargo.toml` for new projects.][cargo/9282] Rustdoc ----------------------- - [Added the `rustdoc::bare_urls` lint that warns when you have URLs without hyperlinks.][81764] Compatibility Notes ------------------- - [Implement token-based handling of attributes during expansion][82608] - [`Ipv4::from_str` will now reject octal format IP addresses in addition to rejecting hexadecimal IP addresses.][83652] The octal format can lead to confusion and potential security vulnerabilities and [is no longer recommended][ietf6943]. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Rework the `std::sys::windows::alloc` implementation.][83065] - [rustdoc: Don't enter an infer_ctxt in get_blanket_impls for impls that aren't blanket impls.][82864] - [rustdoc: Only look at blanket impls in `get_blanket_impls`][83681] - [Rework rustdoc const type][82873] [83386]: rust-lang/rust#83386 [82771]: rust-lang/rust#82771 [84147]: rust-lang/rust#84147 [84082]: rust-lang/rust#84082 [83799]: rust-lang/rust#83799 [83681]: rust-lang/rust#83681 [83652]: rust-lang/rust#83652 [83387]: rust-lang/rust#83387 [82873]: rust-lang/rust#82873 [82864]: rust-lang/rust#82864 [82608]: rust-lang/rust#82608 [82565]: rust-lang/rust#82565 [80525]: rust-lang/rust#80525 [79278]: rust-lang/rust#79278 [78618]: rust-lang/rust#78618 [77704]: rust-lang/rust#77704 [83941]: rust-lang/rust#83941 [83065]: rust-lang/rust#83065 [81764]: rust-lang/rust#81764 [81469]: rust-lang/rust#81469 [cargo/9298]: rust-lang/cargo#9298 [cargo/9282]: rust-lang/cargo#9282 [cargo/9392]: rust-lang/cargo#9392 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`AtomicBool::fetch_update`]: https://doc.rust-lang.org/std/sync/atomic/struct.AtomicBool.html#method.fetch_update [`AtomicPtr::fetch_update`]: https://doc.rust-lang.org/std/sync/atomic/struct.AtomicPtr.html#method.fetch_update [`BTreeMap::retain`]: https://doc.rust-lang.org/std/collections/struct.BTreeMap.html#method.retain [`BTreeSet::retain`]: https://doc.rust-lang.org/std/collections/struct.BTreeSet.html#method.retain [`BufReader::seek_relative`]: https://doc.rust-lang.org/std/io/struct.BufReader.html#method.seek_relative [`DebugStruct::non_exhaustive`]: https://doc.rust-lang.org/std/fmt/struct.DebugStruct.html#method.finish_non_exhaustive [`Duration::MAX`]: https://doc.rust-lang.org/std/time/struct.Duration.html#associatedconstant.MAX [`Duration::ZERO`]: https://doc.rust-lang.org/std/time/struct.Duration.html#associatedconstant.ZERO [`Duration::is_zero`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.is_zero [`Duration::saturating_add`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.saturating_add [`Duration::saturating_mul`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.saturating_mul [`Duration::saturating_sub`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.saturating_sub [`ErrorKind::Unsupported`]: https://doc.rust-lang.org/std/io/enum.ErrorKind.html#variant.Unsupported [`Option::insert`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.insert [`Ordering::is_eq`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.is_eq [`Ordering::is_ge`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.is_ge [`Ordering::is_gt`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.is_gt [`Ordering::is_le`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.is_le [`Ordering::is_lt`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.is_lt [`Ordering::is_ne`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.is_ne [`OsStr::eq_ignore_ascii_case`]: https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.eq_ignore_ascii_case [`OsStr::is_ascii`]: https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.is_ascii [`OsStr::make_ascii_lowercase`]: https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.make_ascii_lowercase [`OsStr::make_ascii_uppercase`]: https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.make_ascii_uppercase [`OsStr::to_ascii_lowercase`]: https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.to_ascii_lowercase [`OsStr::to_ascii_uppercase`]: https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.to_ascii_uppercase [`Peekable::peek_mut`]: https://doc.rust-lang.org/std/iter/struct.Peekable.html#method.peek_mut [`Rc::decrement_strong_count`]: https://doc.rust-lang.org/std/rc/struct.Rc.html#method.increment_strong_count [`Rc::increment_strong_count`]: https://doc.rust-lang.org/std/rc/struct.Rc.html#method.increment_strong_count [`Vec::extend_from_within`]: https://doc.rust-lang.org/beta/std/vec/struct.Vec.html#method.extend_from_within [`array::from_mut`]: https://doc.rust-lang.org/beta/std/array/fn.from_mut.html [`array::from_ref`]: https://doc.rust-lang.org/beta/std/array/fn.from_ref.html [`cmp::max_by_key`]: https://doc.rust-lang.org/beta/std/cmp/fn.max_by_key.html [`cmp::max_by`]: https://doc.rust-lang.org/beta/std/cmp/fn.max_by.html [`cmp::min_by_key`]: https://doc.rust-lang.org/beta/std/cmp/fn.min_by_key.html [`cmp::min_by`]: https://doc.rust-lang.org/beta/std/cmp/fn.min_by.html [`f32::is_subnormal`]: https://doc.rust-lang.org/std/primitive.f64.html#method.is_subnormal [`f64::is_subnormal`]: https://doc.rust-lang.org/std/primitive.f64.html#method.is_subnormal [ietf6943]: https://datatracker.ietf.org/doc/html/rfc6943#section-3.1.1

m-ou-se added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 26, 2021

rust-highfive assigned kennytm Feb 26, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2021

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2021

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 23, 2021

m-ou-se force-pushed the ununstabilize-bits branch 2 times, most recently from 93300de to b0602b4 Compare March 24, 2021 21:33

m-ou-se added 2 commits March 24, 2021 22:34

Revert "Revert stabilizing integer::BITS."

81932be

Bump int_bits_const stable version to 1.53.

bacd522

m-ou-se force-pushed the ununstabilize-bits branch from b0602b4 to bacd522 Compare March 24, 2021 21:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2021

kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 25, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 25, 2021

bors merged commit bba4088 into rust-lang:master Mar 25, 2021

rustbot added this to the 1.53.0 milestone Mar 25, 2021

bors mentioned this pull request Mar 25, 2021

Stabilize vecdeque_binary_search #83362

Merged

joshtriplett mentioned this pull request Mar 31, 2021

Tracking Issue for feature(int_bits_const): <integer>::BITS #76904

Closed

Mark-Simulacrum mentioned this pull request May 25, 2021

regression: BITS constant conflicts in lexical crates #85667

Closed

m-ou-se deleted the ununstabilize-bits branch February 16, 2022 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert reverting of stabilizing integer::BITS. #82565

Revert reverting of stabilizing integer::BITS. #82565

Uh oh!

m-ou-se commented Feb 26, 2021

Uh oh!

rust-highfive commented Feb 26, 2021

Uh oh!

kennytm commented Feb 27, 2021

Uh oh!

bors commented Feb 27, 2021

Uh oh!

bors commented Feb 27, 2021

Uh oh!

kennytm commented Feb 27, 2021

Uh oh!

craterbot commented Feb 27, 2021

Uh oh!

craterbot commented Mar 13, 2021

Uh oh!

Muximize commented Mar 19, 2021

Uh oh!

m-ou-se commented Mar 21, 2021

Uh oh!

craterbot commented Mar 23, 2021

Uh oh!

kennytm commented Mar 23, 2021 •

edited

Loading

Uh oh!

m-ou-se commented Mar 24, 2021

Uh oh!

bors commented Mar 24, 2021

Uh oh!

bors commented Mar 25, 2021

Uh oh!

bors commented Mar 25, 2021

Uh oh!

Uh oh!

Revert reverting of stabilizing integer::BITS. #82565

Revert reverting of stabilizing integer::BITS. #82565

Uh oh!

Conversation

m-ou-se commented Feb 26, 2021

Uh oh!

rust-highfive commented Feb 26, 2021

Uh oh!

kennytm commented Feb 27, 2021

Uh oh!

bors commented Feb 27, 2021

Uh oh!

bors commented Feb 27, 2021

Uh oh!

kennytm commented Feb 27, 2021

Uh oh!

craterbot commented Feb 27, 2021

Uh oh!

craterbot commented Mar 13, 2021

Uh oh!

Muximize commented Mar 19, 2021

Uh oh!

m-ou-se commented Mar 21, 2021

Uh oh!

craterbot commented Mar 23, 2021

Uh oh!

kennytm commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-ou-se commented Mar 24, 2021

Uh oh!

bors commented Mar 24, 2021

Uh oh!

bors commented Mar 25, 2021

Uh oh!

bors commented Mar 25, 2021

Uh oh!

Uh oh!

kennytm commented Mar 23, 2021 •

edited

Loading