Skip to content

Document Res and its friends #82958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

Document Res and its friends #82958

merged 1 commit into from
Apr 8, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Mar 10, 2021

I noticed this Zulip conversation and thought it would be a good idea to
document Res and the other types near it.

@camelid camelid added A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Mar 10, 2021
@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2021
camelid
camelid commented Mar 10, 2021
View reviewed changes
jyn514
jyn514 reviewed Mar 10, 2021
View reviewed changes
@jyn514 jyn514 removed the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Mar 10, 2021
@jyn514
Copy link
Member

jyn514 commented Mar 10, 2021

r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned lcnr Mar 10, 2021
lcnr
lcnr reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of nits and suggestions

i think these comments are really helpful, thanks ❤️

camsteffen
camsteffen reviewed Mar 10, 2021
View reviewed changes
petrochenkov
petrochenkov reviewed Mar 10, 2021
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2021
@crlf0710
Copy link
Member

@camelid Ping from triage! Any updates on this?

@camelid
Copy link
Member Author

camelid commented Mar 27, 2021

Yeah, it's on my todo list, I just need to sit down and address all the comments :)

@camelid
Copy link
Member Author

camelid commented Apr 6, 2021 •
edited
Loading

I think this is almost ready! Unresolved reviews:

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2021
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2021
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2021
@camelid
Copy link
Member Author

camelid commented Apr 6, 2021

Ok, all the reviews have been resolved! 🎉

Let me know if you want me to squash and then this should be ready to merge.

@petrochenkov
Copy link
Contributor

r=me with commits squashed.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2021
@camelid
Copy link
Member Author

camelid commented Apr 8, 2021

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Apr 8, 2021

📌 Commit bc02189e2821b5806070fb08dea388599ab35b0e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 8, 2021
@camelid
Copy link
Member Author

camelid commented Apr 8, 2021

(removed an extraneous period in the docs)

@camelid
Copy link
Member Author

camelid commented Apr 8, 2021

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Apr 8, 2021

📌 Commit 8563a19 has been approved by petrochenkov

@bors
Copy link
Collaborator

bors commented Apr 8, 2021

⌛ Testing commit 8563a19 with merge 0bbf473...

@bors
Copy link
Collaborator

bors commented Apr 8, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 0bbf473 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 8, 2021
@bors bors merged commit 0bbf473 into rust-lang:master Apr 8, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 8, 2021
@camelid camelid deleted the res-docs branch April 8, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@lcnr lcnr lcnr left review comments

+2 more reviewers

@camsteffen camsteffen camsteffen left review comments

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@petrochenkov petrochenkov

Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-enhancement Category: An issue proposing an enhancement or a PR with one. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
9 participants
@camelid @rust-highfive @jyn514 @crlf0710 @petrochenkov @bors @camsteffen @lcnr @rustbot