Add "some" as a doc alias for "any". #86554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Here is someone that was looking for "some": https://internals.rust-lang.org/t/add-some-function-to-iter/14902 |
|
I think we cannot accept new aliases right now, see #84474 (comment). |
|
I understand that slippery slope, but I think this one may still be worth slipping in to pair with the alias on "all". |
|
Hmm, I don't have a strong understanding/opinion here but I agree that this keeps consistency with #81697. Anyway I nominated the subject for the next t-libs meeting (rust-lang/libs-team#18) so someone from t-libs will handle this once it gets a consensus. |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 7, 2021
Revert "Add "every" as a doc alias for "all"." This reverts commit 3545036 (rust-lang#81697) for "every" and closes rust-lang#86554 in kind for "some". The new [doc alias policy](https://std-dev-guide.rust-lang.org/documentation/doc-alias-policy.html) is that we don't want language-specific aliases like these JavaScript names, and we especially don't want to conflict with real names. While "every" is okay in the latter regard, its natural pair "some" makes a doc-search collision with `Option::Some`. r? `@m-ou-se`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 7, 2021
Revert "Add "every" as a doc alias for "all"." This reverts commit 3545036 (rust-lang#81697) for "every" and closes rust-lang#86554 in kind for "some". The new [doc alias policy](https://std-dev-guide.rust-lang.org/documentation/doc-alias-policy.html) is that we don't want language-specific aliases like these JavaScript names, and we especially don't want to conflict with real names. While "every" is okay in the latter regard, its natural pair "some" makes a doc-search collision with `Option::Some`. r? ``@m-ou-se``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches Array#some in JavaScript.
See also #81697 for the alias between "every" and "all".