Skip to content

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Dec 7, 2021

Split from #91403

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 7, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Dec 7, 2021

r=me with the match simplified

@cjgillot
Copy link
Contributor Author

cjgillot commented Dec 7, 2021

r=me with the match simplified

Which match do you mean?

Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I can't seem to figure out the mobile app, I should probably uninstall it and not try to do reviews on it.

This is the match I meant, the comment was just left as "pending"

@oli-obk
Copy link
Contributor

oli-obk commented Dec 7, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 7, 2021

📌 Commit 54ff721 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
Simplify collection of in-band lifetimes

Split from rust-lang#91403

r? `@oli-obk`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
Simplify collection of in-band lifetimes

Split from rust-lang#91403

r? ``@oli-obk``
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 9, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 11, 2021
Simplify collection of in-band lifetimes

Split from rust-lang#91403

r? ```@oli-obk```
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2021
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91617 (Improve the readability of `List<T>`.)
 - rust-lang#91640 (Simplify collection of in-band lifetimes)
 - rust-lang#91682 (rustdoc: Show type layout for type aliases)
 - rust-lang#91711 (Improve `std::iter::zip` example)
 - rust-lang#91717 (Add deprecation warning for --passes)
 - rust-lang#91718 (give more help in the unaligned_references lint)
 - rust-lang#91782 (Correct since attribute for `is_symlink` feature)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7083f8e into rust-lang:master Dec 11, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 11, 2021
@cjgillot cjgillot deleted the in-band-collect branch December 11, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants