Add a new linting pass for obligations #96092
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: this is currently just a rough cut of the idea being sent in for initial discussion: zulip stream. Nothing in here is properly feature gated.)
This adds a new linting pass for when obligations have been used.
This has been spun out as a prerequisite of #95025, where such a capability was needed in order to lint when
#[deprecated_safe] unsafe fn()
-> closure coercions were used. (Here's an alternate reality branch that implements #95025 using the system being proposed here)@lcnr expressed desire for a similar ability on my review, "mostly to deprecate the
Eq
andPartialEq
impls for function pointers". This example lint has been used in this PR rather than pulling in all the#[deprecated_safe]
changes just to test implementing this new system.