compiletest: never truncate stderr if we'll use it as json #96976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started observing some strange failures in larger ui tests that were caused by environmental conditions (probably paths?) pushing the stderr size over the truncation limit, causing the tests to fail because the ui output wasn't valid json due to the truncation marker. Since that seems like a circumstance we never want, just never truncate output that we'll interpret as json output.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
#96551 is probably the approach we're going to pursue here - the truncation is not itself useful, but rather a mechanism to avoid e.g. oom or other hangs in CI. It also helps keep the amount of output down. |
|
Going to close in favor of that PR, but feel free to comment there if you disagree or have thoughts. |
|
That PR looks like a better overall path. I look forward to it landing! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started observing some strange failures in larger ui tests that were
caused by environmental conditions (probably paths?) pushing the stderr
size over the truncation limit, causing the tests to fail because the ui
output wasn't valid json due to the truncation marker. Since that seems
like a circumstance we never want, just never truncate output that we'll
interpret as json output.