Skip to content

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Dec 3, 2024

I should have added them in the previous PR but forgot

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test with nm or so on the exposed symbols?

@arielb1
Copy link
Contributor Author

arielb1 commented Dec 3, 2024

Should we have a test with nm or so on the exposed symbols?

I don't think it's worth it. No C project I know of does this test and I don't see how this one is different.

@Mark-Simulacrum Mark-Simulacrum merged commit 2cdc89e into rust-lang:main Dec 3, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants