Skip to content

Conversation

@BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Nov 22, 2024

Some small stuff: flattens some very nested chapters into only one layer of nesting, replace some old terminology with new terminolgoy, add a note to the early/late bound chapters warning ppl that they talk about some advanced stuff that was not yet covered. also removes the section on representing constants since it really doesn't go into much detail at all, is somewhat out of date, and talks a lot about generic_const_exprs stuff which isn't super important to talk about

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BoxyUwU BoxyUwU merged commit 787b416 into rust-lang:master Nov 22, 2024
1 check passed
@marxin
Copy link
Contributor

marxin commented Dec 29, 2024

@BoxyUwU

Can you please fix the following 2 orphan links:

error: File not found: ../early-late-bound-params/early-late-bound-summary.md
   ┌─ ty_module/param_ty_const_regions.md:13:177
   │
13 │ - [`TyKind::Param`]/[`ConstKind::Param`]/[`RegionKind::EarlyParam`] for early bound generic parameters (note: all type and const parameters are considered early bound, see the [chapter on early vs late bound parameters][ch_early_late_bound] for more information)
   │                                                                                                                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File not found: ../early-late-bound-params/early-late-bound-summary.md

error: File not found: ../early-late-bound-params/early-late-bound-summary.md
   ┌─ ty_module/param_ty_const_regions.md:68:251
   │
68 │ In contrast to `Ty`/`Const`'s `Param` singular `Param` variant, lifetimes have two variants for representing region parameters: [`RegionKind::EarlyParam`] and [`RegionKind::LateParam`]. The reason for this is due to function's distinguishing between [early and late bound parameters](../early-late-bound-params/early-late-bound-summary.md) which is discussed in an earlier chapter (see link).
   │                                                                                                                                                                                                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File not found: ../early-late-bound-params/early-late-bound-summary.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants