Document josh subtrees and update subtree repository list #2182
Conversation
src/external-repos.md
Outdated
|
|
||
| `subtree` dependencies are currently managed by two distinct approaches: | ||
|
|
||
| * Using `git subtree` directly |
There was a problem hiding this comment.
| * Using `git subtree` directly | |
| * Using `git subtree` |
There's no "indirect" usage so I find the additional qualifier confusing
There was a problem hiding this comment.
I wanted to distinguish "using subtrees via josh" and "using subtrees via git subtree", but the word was extraneous, I suppose. Removed it.
src/external-repos.md
Outdated
| ## External Dependencies (subtrees) | ||
|
|
||
| As a developer to this repository, you don't have to treat the following external projects | ||
| differently from other crates that are directly in this repo: |
There was a problem hiding this comment.
That's not quite true, tools generally prefer PRs to their own repos when changes don't have to be done in lockstep with Rust compiler changes.
There was a problem hiding this comment.
This was pre-existing, but I agree it was confusing, I reworded it.
jieyouxu
added
S-waiting-on-review
|
|
||
| `subtree` dependencies are currently managed by two distinct approaches: | ||
|
|
||
| * Using `git subtree` |
There was a problem hiding this comment.
portable-simd also uses this; it seems to be entirely missing from this list?
There was a problem hiding this comment.
The list was incomplete before, I added a few entries, but since there was no global list before that, I didn't notice portable-simd. Good catch! Added it in #2214.
3 participants
Mention our usage of josh in
miriandrust-analyzer, and add the cranelift backend to the list.