Add "Writing tests" section in getting-started.md #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
reviewed
Jan 29, 2025
src/getting-started.md
Outdated
|
|
||
| ### Writing tests | ||
|
|
||
| Issues that have been resolved but do not have a regression test are marked with the `E-needs-test` label. Writing unit tests is a low-risk, lower-priority task that offers new contributors a great opportunity to familiarize themselves with the codebase. |
Member
There was a problem hiding this comment.
Nit: not necessarily the codebase, but maybe testing infrastructure / contribution workflow.
Contributor
Author
There was a problem hiding this comment.
Nit: not necessarily the codebase, but maybe testing infrastructure / contribution workflow.
Your suggestion makes more sense, thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2069.
I added a short section mentioning
E-needs-testlabel in getting-started.md