Skip to content

Conversation

rylev
Copy link
Member

@rylev rylev commented Aug 11, 2022

Fixes #1390

Previously the handler for unrolling rollups assumed that the commits were ordered bor's auto merge, all roll up merges, all individual commits (in reverse order), but this is not always true. In rust-lang/rust#100356 for example, an individual commit made it in between roll up merge commits.

This simplifies the code to not make this assumption.

@rylev rylev requested a review from Mark-Simulacrum August 11, 2022 14:22
@rylev rylev marked this pull request as ready for review August 11, 2022 14:22
@Mark-Simulacrum Mark-Simulacrum merged commit 161b8e9 into rust-lang:master Aug 11, 2022
@rylev rylev deleted the all-roll-ups branch August 11, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GH perf bot message: number of perf builds in rollup reported by perf bot != PR's in rollup

2 participants