Skip to content

Apply forgotten review changes to command parsing #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Apply forgotten review changes to command parsing #1998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions site/src/request_handlers/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,9 @@ async fn handle_rust_timer(
return Ok(github::Response);
}

let build_cmds: Vec<_> = parse_build_commands(&comment.body).collect();
let mut valid_build_cmds = vec![];
let mut errors = String::new();
for cmd in build_cmds {
for cmd in parse_build_commands(&comment.body) {
match cmd {
Ok(cmd) => valid_build_cmds.push(cmd),
Err(error) => errors.push_str(&format!("Cannot parse build command: {error}\n")),
Expand Down Expand Up @@ -208,18 +207,15 @@ fn parse_build_commands(body: &str) -> impl Iterator<Item = Result<BuildCommand,
})
}

fn get_command_lines<'a: 'b, 'b>(
body: &'a str,
command: &'b str,
) -> impl Iterator<Item = &'a str> + 'b {
fn get_command_lines<'a>(body: &'a str, command: &'a str) -> impl Iterator<Item = &'a str> {
let prefix = "@rust-timer";
body.lines()
.filter_map(move |line| {
line.find(prefix)
.map(|index| line[index + prefix.len()..].trim())
})
.filter_map(move |line| line.strip_prefix(command))
.map(move |l| l.trim_start())
.map(|l| l.trim_start())
}

fn parse_benchmark_parameters<'a>(
Expand Down
Loading