Skip to content

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 13, 2025

I did some cleanups beforehand which, while not strictly necessary, were distracting me 😆

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense! The cleanup is also nice.

Left a few nits.

@Kobzol
Copy link
Member

Kobzol commented Jan 14, 2025

There is also profiler diffing for runtime benchmarks (

RuntimeProfiler::Cachegrind => {
), which could be moved to the new "API". But I don't think that it's super important, I can do it later.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 14, 2025

Yea, I wanted to do that, but the enums RuntimeProfiler and Profiler are different, so I didn't do that yet. I think figuring out deduplication for those later is better

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks!

@Kobzol Kobzol merged commit 814271d into rust-lang:master Jan 14, 2025
11 checks passed
@oli-obk oli-obk deleted the push-wtzmtssxzmxz branch January 14, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants