-
Notifications
You must be signed in to change notification settings - Fork 163
Make it easy to add diffing of output of arbitrary profilers (demonstrate for dep-graph) #2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this makes sense! The cleanup is also nice.
Left a few nits.
…ced with the extension
…rate for dep-graph)
41d7cb2 to
0892746
Compare
|
There is also profiler diffing for runtime benchmarks ( rustc-perf/collector/src/bin/collector.rs Line 799 in 700be8c
|
|
Yea, I wanted to do that, but the enums |
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Thanks!
I did some cleanups beforehand which, while not strictly necessary, were distracting me 😆