Add support for selecting workspace package #2078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be useful for local benchmarking of workspace crates.
nnethercote
approved these changes
Apr 25, 2025
Contributor
nnethercote
left a comment
nnethercote
left a comment
There was a problem hiding this comment.
Seems fine, but should something be added to one of the README.md files within collector/?
Member
Author
|
It isn't currently used for any of the benchmarks. I guess that the only current documentation are the doc comments on the |
Contributor
|
Oh, https://github.com/rust-lang/rustc-perf/tree/master/collector/compile-benchmarks is the closest thing to docs we have on Ok, feel free to merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful for local benchmarking of workspace crates.
Extracted out of #2073.