Skip to content

Give full path of binary in example download command. #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Give full path of binary in example download command. #2097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions collector/compile-benchmarks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,10 @@ Rust code being written today.
anything we should be aware of when using this crate as a compile-time
benchmark.
- Look at [crates.io](https://crates.io) to find the latest (non-prerelease) version.
- Download it with `collector download -c $CATEGORY -a $ARTIFACT crate $NAME $VERSION`.
The `$CATEGORY` is probably `Primary`. `$ARTIFACT` is either `library` or `binary`, depending
on what kind of artifact does the benchmark build.
- Download it with `target/release/collector download -c $CATEGORY -a
$ARTIFACT crate $NAME $VERSION`. The `$CATEGORY` is probably `Primary`.
`$ARTIFACT` is either `library` or `binary`, depending on what kind of
artifact does the benchmark build.
- It makes it easier for reviewers if you split things into two commits.
- In the first commit, just add the code for the entire benchmark.
- Do this by doing `git add` on the new directory.
Expand Down
Loading