Skip to content

Use async closures in collector #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

Use async closures in collector #2150

merged 2 commits into from
Jun 11, 2025

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 5, 2025

Finally we can get rid of the cursed passing of Tokio runtime. I tried to do this once some time ago, but it was ~impossible without async closures.

@Kobzol Kobzol force-pushed the async-collector branch from 4ffad70 to dfa95c8 Compare June 5, 2025 13:20
@Kobzol Kobzol force-pushed the async-collector branch from dfa95c8 to c591209 Compare June 5, 2025 14:27
@Kobzol Kobzol requested a review from Mark-Simulacrum June 6, 2025 07:59
@Kobzol
Copy link
Member Author

Kobzol commented Jun 11, 2025

Doing funny business with async is always a bit scary, so I'll monitor the queue if everything seems to be progressing normally.

@Kobzol Kobzol merged commit 8a9b364 into rust-lang:master Jun 11, 2025
11 checks passed
@Kobzol Kobzol deleted the async-collector branch June 11, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kobzol @Mark-Simulacrum