Skip to content

Do not compile extended tools in bootstrap benchmark #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Do not compile extended tools in bootstrap benchmark #2158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions collector/src/compile/execute/rustc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ async fn record(
"build.cargo={}",
toolchain.components.cargo.to_str().unwrap()
))
// Do not compile all default tools
.arg("--set")
.arg("build.extended=false")
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

....why is this on by default? It's literally extended :)

But seems fine.

Copy link
Member Author

@Kobzol Kobzol Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustc-perf runs configure, which creates a config file based on the dist profile. And dist uses extended = true, which I guess makes sense for it.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the goal of the bootstrap timing is really more focused on rustc devs IMO, not distros, so we might want to change that to compiler or so... though maybe this is enough in practice.

Copy link
Member

@lqd lqd Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm², the dist profile doesn't download-ci-llvm, so I hope we're not building llvm on the collector.

Copy link
Member Author

@Kobzol Kobzol Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We enable download CI LLVM a few lines before, don't worry 😅

.status()
.context("configuring")?;
assert!(status.success(), "configure successful");
Expand Down
Loading