Skip to content

bump deps #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 5, 2025
Merged

bump deps #2184

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
88f97df
bump some crates to resolve cargo audit
klensy Jul 3, 2025
e714070
bump clap to drop some deps
klensy Jul 3, 2025
b525379
reduce deps num
klensy Jul 3, 2025
6ecfa10
drop ring
klensy Jul 5, 2025
ca23b56
bless runtime lock files
klensy Jul 5, 2025
9421e32
unpin clap
klensy Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
317 changes: 117 additions & 200 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ resolver = "2"
[workspace.dependencies]
anyhow = "1"
chrono = "0.4"
clap = "4.1"
# this is latest version with small number of deps
clap = "=4.1.14"
Copy link
Member

@Kobzol Kobzol Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that reducing the number of deps is so critical here that we would need to pin specific versions, that should be left to really rare circimstances. Just leave it at "4".

Copy link
Contributor Author

@klensy klensy Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of sources of dep number increase here #2034 (comment) was clap, so i tried to prevent it. Ok.

env_logger = "0.10"
hashbrown = "0.14"
log = "0.4"
Expand Down
81 changes: 10 additions & 71 deletions collector/runtime-benchmarks/bufreader/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

90 changes: 18 additions & 72 deletions collector/runtime-benchmarks/compression/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading