Skip to content

drop thiserror@1 dep #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
Merged

drop thiserror@1 dep #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8118691
transit all deps to thiserrorv2 except direct dep
klensy Jul 10, 2025
d5ac106
bump thiserror direct dep
klensy Jul 10, 2025
23a5ef1
sync pest dep versions too
klensy Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 49 additions & 41 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions collector/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
tokio = { workspace = true, features = ["rt", "process"] }

thiserror = "1"
thiserror = "2"
tempfile = "3"
libc = "0.2"
semver = "1.0"
Expand All @@ -29,7 +29,7 @@ snap = "1"
walkdir = "2"
flate2 = { version = "1.0.22", features = ["rust_backend"] }
rayon = "1"
cargo_metadata = "0.18"
cargo_metadata = "0.19"
thousands = "0.2.0"
rustc-demangle = { version = "0.1", features = ["std"] }
similar = "2.2"
Expand Down
2 changes: 1 addition & 1 deletion collector/src/artifact_stats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ pub fn compile_and_get_stats(
..
} = artifact;
if let Some(executable) = executable {
if target.kind.iter().any(|kind| kind == "bin") {
if target.is_bin() {
let stats = ArtifactStats::from_dynamic_object(executable.as_std_path())
.with_context(|| format!("Cannot parse executable stats from {executable}"))?;
archives.push(ArtifactWithStats {
Expand Down
2 changes: 1 addition & 1 deletion collector/src/runtime/benchmark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ fn parse_benchmark_group(
if let Some(ref executable) = artifact.executable {
// Found a binary compiled by a runtime benchmark crate.
// Execute it so that we find all the benchmarks it contains.
if artifact.target.kind.iter().any(|k| k == "bin") {
if artifact.target.is_bin() {
if group.is_some() {
return Err(anyhow::anyhow!(
"Runtime benchmark group `{group_name}` has produced multiple binaries"
Expand Down
4 changes: 2 additions & 2 deletions site/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ analyzeme = "12.0.0"
inferno = { version = "0.11", default-features = false }
mime = "0.3"
# prometheus currently uses plain text, so disable protobuf
prometheus = { version = "0.13", default-features = false }
prometheus = { version = "0.14", default-features = false }
uuid = { version = "1.3.0", features = ["v4"] }
tera = { version = "1.19", default-features = false }
rust-embed = { version = "6.6.0", features = [
rust-embed = { version = "8.2.0", features = [
"include-exclude",
"interpolate-folder-path",
] }
Expand Down
Loading