Feat; job_queue table definition & mark a request as complete if all jobs are finished #2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamesbarford
force-pushed
the
feat/split-benchmark-requests-to-jobs
branch
3 times, most recently
from
3e1489a to
d0ed82f
Compare
Kobzol
reviewed
Jul 14, 2025
Kobzol
reviewed
Jul 30, 2025
| 1 | ||
| FROM | ||
| job_queue | ||
| WHERE job_queue.request_id = benchmark_request.id |
There was a problem hiding this comment.
Once we also add the parent benchmark tag here, could you please run EXPLAIN to make sure that the jobs (not requests) are looked up by index? Also would be nice to check if requests are accessed by index.
…jobs are finished
…benchmark set made into a a struct
Jamesbarford
force-pushed
the
feat/split-benchmark-requests-to-jobs
branch
from
f7f9747 to
eb422a5
Compare
|
Superseded by; #2214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job_queuetable.job_queue.benchmark_requestas complete if all jobs associated with the request have the status ofsuccessorfailure.I've omitted
job_splittingas this PR is modestly big. However, bar marking things as complete, the PR is fairly mechanical.