Preparation for collector job queue integration #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamesbarford
requested changes
Aug 7, 2025
Jamesbarford
approved these changes
Aug 8, 2025
So that we can call it from async functions.
Since the config can be missing.
We need it to fill the `artifact` table.
Kobzol
force-pushed
the
benchmark-job-queue-preparation
branch
from
16fca1a to
6384992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of changes that I had to do to prepare the collector for integration with the new job queue system. It doesn't contain all the changes, but it should be self-contained enough to land as a separate PR.
Note: the last commit is global
clippy --fix, there was a bunch of warnings accrued.